fix bug: getAll missing observations - #138
Open
annooritdept wants to merge 2 commits into
Open
Conversation
The shortcut on lines 67-69 cause an unexcpected result where, when getAll has numberOfAccessions set, observations for orders will only be attached to orders if their encounter is dated after the last encounter reached by this loop. The solution seems to be to just remove the shortcut.
|
|
Previous bugfix was wrong, would have ignored numberOfAccessions altogether. This is possibly better. I apologize, I don't have a development system set up to test this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shortcut on lines 67-69 LabOrderResultsServiceImpl.java causes an unexcpected result where, when getAll has numberOfAccessions set, observations for orders will only be attached to orders if their encounter is before the last encounter reached by this loop. When using numberOfAccessions, this causes orders to be returned without their associated observed values. The solution seems to be to just remove the shortcut. I haven't tested this.