Repository navigation
feat: check ffmpeg and models, add clean-machine receipt - #14
Merged
Merged
Conversation
joepetjr
changed the base branch from
feat/rc-2-render-receipt-and-stale-install
to
main
October 1, 2026 15:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RC-3 from the portfolio remediation plan, narrowed.
--check-depsand the onnxruntime extra already existed. This adds the missing checks. Stacked on the RC-2 branch; the diff against that branch is 855 lines.redact_video()callsrequire_ffmpeg()first. A missing ffmpeg or ffprobe raisesFfmpegUnavailableErrorwith an install hint before detection starts.--check-depsexits 1 when ffmpeg or ffprobe is missing.--skip-ffmpegopts out.--check-deps --model KIND=PATHhashes each supplied model file, loads its detector and runs one blank-frame inference.--check-deps --receipt FILEruns every check, requires all four model files, never downloads weights, renders a synthetic ffmpeg test clip through the pipeline and writesredactcam.clean-machine-receipt/v1. It exits 0 only when everything passed.Design decisions made by the author (please review)
release.ymlsmoke test becomesredactcam.exe --check-deps --skip-ffmpeg, because the release runner has no ffmpeg and the stricter check would fail the build.tests/test_packaging.pyasserts it.--receiptand--skip-ffmpegwithout--check-deps, and the two together, are parser errors.Test plan
ruff check .clean.tests/test_qualify.pyfailed withImportError: cannot import name 'qualify'; the ffmpeg gate test failed withAttributeError ... has no attribute 'require_ffmpeg'.Acceptance
--check-deps: met.Not in this PR