Repository navigation
fix(cleanup): find a drive health backlog staged one level deeper - #305
Merged
Merged
Conversation
health backlog stages a drive at <stages root>/<project>/<project>/_stages; cleanup looked only at <base>/<project>/_stages, so the published US-64 drive (187 GB on C:) was skipped and nothing was freed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
gomoveshift cleanupnow finds a drive in the layouthealth backlogstages it in,<stages root>/<project>/<project>/_stages:<stage cache>/<project>/<project>; the one holding_stagesstill wins_stagesof its own is checked one level down under its own nameWhy
2026-11-10:
cleanup sc-2026-02-24-us64-waterfall-byway --min-age 0withGMS_INTERMEDIATE_DIR=/mnt/c/WorkspacesGMSStagesfreed nothing. The published drive's 187 GB sits at/mnt/c/WorkspacesGMSStages/sc-2026-02-24-us64-waterfall-byway/sc-2026-02-24-us64-waterfall-byway/_stages, one level deeper than cleanup looked, so it was skipped as "pipeline not complete". C: stayed at 151 GB free, below the 207.7 GB that the next NC→PA drive's storage preflight needs.Tests
Two new cases in
tests/test_cleanup_drive_cache.py, red before (assert 2 == 0with the "Pipeline not complete" SKIP for the named form; "No projects found." for discovery). Cleanup suites: 92 passed. ruff clean. README and changelog fragment updated.