Repository navigation
chore(deps): pin keycut v0.2.0 and validate its live assembly receipt - #108
Merged
Merged
Conversation
Move the keycut pin from v0.1.0 to v0.2.0. The day-master cut (extract_and_concat_segments) now calls keycut's extract_and_concat_ranges_with_receipt and checks the receipt it returns with our own load_receipt. If the receipt does not validate, the function logs an error naming the failing field and returns None, because an output-to-source time map built from a bad receipt would be wrong. The signature and return type are unchanged. keycut 0.1.2 changed the re-encode fallback to seek on the input side (-ss S -i master -ss 0 -t D). montage_builder.reencode_range_argv mirrors that argv, so it follows; the lead-seam cut gives the same frames without decoding from the start of the file. keycut 0.2.0 also probes piece and output durations for the receipt, so the clean-run command count in the resume test goes from 4 to 7. Add a real-ffmpeg test that runs keycut on a synthetic master, loads the live receipt, maps output time back to source time, and compares the receipt's keys with the frozen assembly_receipt_v1.json fixture.
# Conflicts: # gomoveshift/pipeline/montage_builder.py # pyproject.toml
Contributor
Author
|
Hard-denied (hard-deny: protected path family) and ready to merge -- all checks green. Offending paths:
Human merge (all 3 ready hard-denied PRs in Back-Road-Creative/framegrade): This PR alone: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
keycutto v0.2.0, up from v0.1.2 (chore(release): 0.3.12, keycut v0.1.2 #105).day_pipeline.extract_and_concat_segmentsnow calls keycut'sextract_and_concat_ranges_with_receipt, keeping every argument, and checks the live receipt with framegrade'sload_receipt.Why
This is unit Q3j of the media-quality / GPS-overlay plan. framegrade's receipt loader and
EditTimeline.from_receiptwere built against a frozen fixture. This PR proves that a real keycut receipt passes them.Tests
tests/test_keycut_live_receipt.py:tests/fixtures/assembly_receipt_v1.jsonat every level.test_inserts; the mirror itself landed in chore(release): 0.3.12, keycut v0.1.2 #105)test_resume_correctness_segments)test_segment_extractornow return(path, receipt)edit_timelineormontage_builder, plus the changelog and docs suites, gave 544 passed and 1 failed.test_installed_vcs_pins_match_pyproject. The local venv has older redactcam and seo-manager commits than main pins; keycut is not on its drift list. CI installs fresh.ruff checkandruff format --checkare clean, andtools/check_public_tree.pypasses.