Skip to content

test(tokenizer): skip tiktoken tests when encoding blob access is forbidden #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BaSui01 merged 2 commits into from
May 13, 2026
Merged

test(tokenizer): skip tiktoken tests when encoding blob access is forbidden #57

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f225a4a
test(tokenizer): skip tiktoken network-dependent checks when encoding…
BaSui01 May 11, 2026
f8cc00f
fix: gofmt tiktoken_test.go
May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions llm/tokenizer/tiktoken_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package tokenizer

import (
"strings"
"testing"

"github.com/pkoukk/tiktoken-go"
Expand Down Expand Up @@ -67,6 +68,16 @@ func TestNewTiktokenTokenizer(t *testing.T) {
}
}

func requireTiktokenAvailable(t *testing.T, tok *TiktokenTokenizer) {
t.Helper()
if _, err := tok.CountTokens("health-check"); err != nil {
if strings.Contains(err.Error(), "Forbidden") || strings.Contains(err.Error(), "403") {
t.Skipf("tiktoken encoding download unavailable in current environment: %v", err)
}
require.NoError(t, err)
}
}

func TestTiktokenTokenizer_PrefixMatch(t *testing.T) {
// "gpt-4o-mini" should match "gpt-4o" prefix
tok, err := NewTiktokenTokenizer("gpt-4o-mini")
Expand All @@ -80,6 +91,7 @@ func TestTiktokenTokenizer_CountTokens(t *testing.T) {

tok, err := NewTiktokenTokenizer("gpt-4")
require.NoError(t, err)
requireTiktokenAvailable(t, tok)

count, err := tok.CountTokens("Hello, world!")
require.NoError(t, err)
Expand All @@ -91,6 +103,7 @@ func TestTiktokenTokenizer_Encode_Decode(t *testing.T) {

tok, err := NewTiktokenTokenizer("gpt-4")
require.NoError(t, err)
requireTiktokenAvailable(t, tok)

text := "Hello, world!"
tokens, err := tok.Encode(text)
Expand All @@ -107,6 +120,7 @@ func TestTiktokenTokenizer_CountMessages(t *testing.T) {

tok, err := NewTiktokenTokenizer("gpt-4")
require.NoError(t, err)
requireTiktokenAvailable(t, tok)

messages := []Message{
{Role: "user", Content: "Hello"},
Expand All @@ -122,13 +136,17 @@ func TestTiktokenTokenizer_CountMessages(t *testing.T) {
func TestTiktokenTokenizer_Name(t *testing.T) {
tok, err := NewTiktokenTokenizer("gpt-4")
require.NoError(t, err)
requireTiktokenAvailable(t, tok)

assert.Contains(t, tok.Name(), "tiktoken")
assert.Contains(t, tok.Name(), "cl100k_base")
}

func TestTiktokenTokenizer_MaxTokens(t *testing.T) {
tok, err := NewTiktokenTokenizer("gpt-4")
require.NoError(t, err)
requireTiktokenAvailable(t, tok)

assert.Equal(t, 8192, tok.MaxTokens())
}

Expand Down
Loading