refactor: eliminate duplicate code across LLM provider and agent layers - #108
Open
BaSui01 wants to merge 10 commits into
Open
refactor: eliminate duplicate code across LLM provider and agent layers#108BaSui01 wants to merge 10 commits into
BaSui01 wants to merge 10 commits into
Annotations
6 errors and 2 warnings
|
Run golangci-lint
issues found
|
|
Run golangci-lint:
llm/providers/base/stream_handler_test.go#L107
Consider pre-allocating `chunks` (prealloc)
|
|
Run golangci-lint:
api/handlers/agent.go#L711
Error return value is not checked (errcheck)
|
|
Run golangci-lint:
api/handlers/agent.go#L664
unnamedResult: consider giving a name to these results (gocritic)
|
|
Run golangci-lint:
agent/execution/protocol/a2a/server_test.go#L135
httpNoBody: http.NoBody should be preferred to the nil request body (gocritic)
|
|
Run golangci-lint:
agent/execution/protocol/a2a/client.go#L214
shadow: declaration of "err" shadows declaration at line 195 (govet)
|
|
Complete job
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/checkout@v4, actions/setup-go@v5, actions/upload-artifact@v4, golangci/golangci-lint-action@v6. Actions will be forced to run with Node.js 24 by default starting June 16th, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Upload CI artifacts
No files were found with the provided path: coverage.out
coverage-summary.txt. No artifacts will be uploaded.
|
background
wait
wait-all
cancel
parallel
Loading