fix(npu): add Ascend CPU fallback for COO ops and fix segment_reduce stream - #18
Open
xuejiakn wants to merge 1 commit into
Open
fix(npu): add Ascend CPU fallback for COO ops and fix segment_reduce stream#18xuejiakn wants to merge 1 commit into
xuejiakn wants to merge 1 commit into
Conversation
…stream - array.cc: add CPU fallback with aclrtSynchronizeDevice() for 5 COO operations that previously only dispatched to CPU/CUDA (not Ascend): - COOGetRowNNZ (scalar + array) - COOGetRowDataAndIndices - COOSliceRows(NDArray) - COOSort_ - Also add aclrtSynchronizeDevice() to existing COOGetDataAndIndices/COOGetData - segment_reduce.cc: - Use default stream (nullptr) instead of custom stream - Use synchronous aclrtMemcpy instead of aclrtMemcpyAsync - Add aclrtSynchronizeDevice() at entry to ensure PyTorch ops complete - unit_graph.cc: InEdges() prefers COO format on Ascend to avoid CSR kernel stream sync issues (COO InEdges uses CPU fallback which is more reliable)
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add Ascend CPU fallback for COO-format ops and fix segment_reduce stream sync.
Changes
Restructure note
Replaces #14[4] and #15[7] (identical).