π‘οΈ Sentinel: [CRITICAL] Fix Device JWT Subject Spoofing (Privilege Escalation) - #921
π‘οΈ Sentinel: [CRITICAL] Fix Device JWT Subject Spoofing (Privilege Escalation)#921ToolchainLab wants to merge 1 commit into
Conversation
Added explicit verification in `verify_device_jwt` to ensure the `sub` claim on device-signed JWTs matches the actual owner of the device (`device.user_id`). This prevents users from forging tokens to impersonate other users (privilege escalation). Co-authored-by: ToolchainLab <263750431+ToolchainLab@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Device-signed JWTs trusted the
subclaim without verifying it matched the device owner'suser_id, allowing an attacker with one valid device key to impersonate any user.π― Impact: Privilege escalation / full account takeover. A valid user could forge tokens for admins or other users.
π§ Fix: Added explicit enforcement of
claims.sub == device.user_idduring JWT verification inverify_device_jwt.β Verification: Ran
uv run pytest. The test suite confirmed valid tokens pass andtest_exploit.pyconfirmed spoofed tokens fail withSubject mismatch.PR created automatically by Jules for task 3279532018961842619 started by @ToolchainLab