⚡ Bolt: Use db.scalar() instead of db.execute().scalars().first() for database fetches - #919
⚡ Bolt: Use db.scalar() instead of db.execute().scalars().first() for database fetches#919ToolchainLab wants to merge 1 commit into
Conversation
Replaces instances of `await db.execute(...).scalars().first()` with `await db.scalar(...)` in authentication pathways and CLI components to reduce SQLAlchemy execution result instantiation overhead. Also optimizes a specific existence-check query to just fetch the user ID instead of the full model. Co-authored-by: ToolchainLab <263750431+ToolchainLab@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Refactored
db.execute(stmt).scalars().first()todb.scalar(stmt). Also updated one query to only fetch the primary key (db.scalar(select(User.id)...)) when checking for existence.🎯 Why: Prevents unnecessary query execution and iteration steps, which provides small but frequent wins in hot paths like auth. Fetching only the primary key avoids hydrating the entire ORM object unnecessarily.
📊 Impact: Reduces SQLAlchemy overhead and memory allocations during database fetches.
🔬 Measurement: Profiling
.execute().scalars().first()vs.scalar()shows a measurable reduction in CPU time when querying single records.PR created automatically by Jules for task 10190036784636829498 started by @ToolchainLab