feat: add support event message toggle - #34
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
https://github.com/BP602/KickTalk/blob/dc86e7f9147a1d3bab30532db4cacc4a51168044/src/renderer/src/components/Messages/MessagesHandler.jsx#L27-L35
[P2] Respect silenced users for support event messages
The new support-event message types (subscription, donation, reward, stream_*) bypass the silencing filter. The filtering logic returns early for any message whose type is neither reply nor message, so the silencedUserIds check is never applied. As a result, silenced users’ support events will still render even though their regular chat messages are hidden, which defeats the point of silencing disruptive users who spam donations or subs. Consider applying the silencedUserIds filter whenever a message carries a sender.id, regardless of its type, or explicitly filtering these new types alongside standard messages.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
|
test cases
|
…telemetry - Add explicit handlers for ChannelSubscriptionEvent and GiftsLeaderboardUpdated - Fix channel extraction regex to handle reward events from chatroom_* format - Enhance SupportEventMessage with sparkle icon and structured formatting - Add comprehensive SCSS styling for reward events with custom backgrounds - Fix context menu to hide reply option for support events (no content field) - Add telemetry span creation for ReplyCapture validation errors with rich attributes - Fix profile link fallback to use username when slug is undefined
Add handling for gift subscriptions, donations, rewards, and regular subs in SupportEventMessage.jsx, including gifted user display, count/total logic, and event-specific colors/backgrounds. Update Message.scss with icon tints (purple for subs, green for donations, gold for rewards, warm for gifts) and styling for usernames, actions, costs, and counts. Introduce gift-box.svg icon and import sparkle/gift icons. Minor updates to Message.jsx rendering, ChatProvider.jsx, CosmeticsProvider.jsx for metadata parsing, and sharedKickPusher.js for event processing. Add untracked donation-replay.js for replay functionality.
- Show "StreamerName is now live: Title" with red bg + record icon - Show "StreamerName has ended the stream" with gray bg + eye icon - Add clickable usernames and bold keywords - Integrate with existing support events system
dc86e7f to
a3fe477
Compare
Added "ws" (^8.18.3) to dependencies for WebSocket support in the application. Introduced npm scripts "collect-events" and "analyze-events" to run event collector and analyzer tools from scripts/event-collection, enabling easier debugging and performance analysis of user events. Updated package-lock.json accordingly.
Refactor the SupportEventMessage component to use Phosphor Icons library instead of individual SVG assets for event types (reward, subscription, donation, stream_live, stream_end). This replaces <img> tags with conditional icon components, adds consistent sizing (24px), fill weights where needed, and improves accessibility by moving alt text to aria-labels on icons.
…pe support Normalize ChatMessageEvent type "celebration" (metadata.celebration.type=subscription_*) to support:subscription with months from total_months Add 15s dedupe across celebration-derived and explicit Subscription|Donation|Tip|Reward events to prevent duplicates Add pooled receiver catch‑all: emit raw for unknown non‑pusher events mapped to chatrooms; telemeter unknown_event_mapped/unmapped Wire raw through ConnectionManager and ChatProvider; record telemetry only (no UI impact) Update docs/kick-websocket-channels.md with celebration subtype and classification guidance
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback". |
… handling - Add chat mode telemetry tracking with type mismatch detection - Implement comprehensive support event parsing (host, raid, goal progress, moderation) - Update InfoBar with unified chat mode detection logic across multiple sources - Add ChatEvents settings section for event configuration - Enhance SupportEventMessage with typed icons and structured data display - Add safeChatroomIdMatch helper with telemetry reporting for ID type mismatches - Update connection manager and Kick API services for improved event handling - Remove large event collection file from git tracking (kept in .gitignore)
|
@codex review |
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
|
Aso fixed emote only mode not being recognized |
1 participant
Summary
Testing
npm run linthttps://chatgpt.com/codex/tasks/task_e_68ba26fb56c0833198caf45126aadeb7