feat: improve @mention detection accuracy and performance - #23
Merged
Merged
Conversation
- Add strict username-specific mention regex with proper boundaries - Handle username variations with hyphens/underscores interchangeably - Separate notification triggers (sound vs background highlighting) - Memoize mention regex to avoid rebuilding on every message - Fix mention rendering to exclude boundary characters from highlight - Add username variant lookup for clickable mentions
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
- Move mention regex logic to shared utils/regex.js with createMentionRegex() - Replace duplicate regex patterns in ChatProvider and Message.jsx - Fix notifications ignoring punctuation like @user! and @user? - Ensure consistent mention detection across notification and highlighting systems Addresses punctuation handling issue in codex comment
ftk789
added a commit
that referenced
this pull request
Oct 14, 2025
* Fix cross-platform icon compatibility - Add cross-platform icon handling for Linux/macOS support - Convert Windows .ico to .png for non-Windows platforms - Update tray and thumbar icons to use platform-appropriate format Fixes application crashes on Linux due to unsupported .ico format 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * Implement draft message persistence between chatroom switches - Add draft storage to ChatProvider state using Map for per-chatroom drafts - Create DraftManager component to handle automatic saving and restoration - Save draft content on editor changes using Lexical update listeners - Restore draft content when switching back to chatrooms - Clear drafts when messages are sent successfully - Fix Lexical node structure by properly using paragraph nodes Fixes #23 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: ftk789 <57598907+ftk789@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes Made
Test Plan
Fixes #14