ECT: CheckAreaLedger - #7245
Open
aarontran wants to merge 1 commit into
Open
Conversation
When using embedded boundary with enlarged-cell technique (ECT) solver, check that global face area is conserved (lent area = borrowed area) to within an automatically-determined round-off error tolerance. Also check that S_mod > 0 for all participating faces to guard against an edge case wherein multiple unstable cells can "overdraft" a neighbor cell's available area.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using embedded boundary with enlarged-cell technique (ECT) solver, check that global face area is conserved (lent area = borrowed area) to within an automatically-determined round-off error tolerance. Also check that S_mod > 0 for all participating faces to guard against an edge case wherein multiple unstable cells can "overdraft" a neighbor cell's available area.
This PR was created to help test PR #7104, which fixes area-conservation bugs related to cross-box synchronization of lent/borrowed face area.
During review of PR #7104, it was also noticed that S_mod < 0 on a face may occur due to at least one pathological case of an under-resolved embedded boundary with cut-cells at AMReX box corners. The present PR simply aborts and does not attempt to re-work the ECT algorithm for a relatively obscure edge case.
Questions and notes for reviewers:
verbose >=1or> 1?Example logging if checks passed for a 2D simulation:
Example logging if a check fails: