Skip to content

Docs: record where CI is configured in AGENTS.md - #7236

Merged
ax3l merged 5 commits into
BLAST-WarpX:developmentfrom
RemiLehe:document_ci_layout
Sep 3, 2026
Merged

Docs: record where CI is configured in AGENTS.md#7236
ax3l merged 5 commits into
BLAST-WarpX:developmentfrom
RemiLehe:document_ci_layout

Conversation

@RemiLehe

@RemiLehe RemiLehe commented Sep 2, 2026

Copy link
Copy Markdown
Member

In several conversations with Claude Opus 5, I have noticed that it seems to accidentally overlook .azure-pipelines.yml. For instance:

Agent: no CI job enables WarpX_PETSC, so that path is unverified [...].

Me: See .azure-pipelines.yml: isn't this using PETSc in CI?

Agent: You're right to push back — I only grepped .github/workflows/ and Regression/, 
never the Azure pipeline. Let me check. [...] I was wrong — this is well covered by CI.

This PR updates the AGENTS.md to prevent this error from recurring.

WarpX splits its CI across two systems, and the split is not obvious:
`.github/workflows/` holds the build-only jobs, while
`.azure-pipelines.yml` builds the dimensionality/feature matrix and runs
the actual `ctest` suite.

The consequence worth writing down is that the Azure matrix carries the
`WARPX_CMAKE_FLAGS` that decide which optional subsystems get compiled at
all -- `WarpX_PETSC=ON`, for instance, is set there for the 1D, 2D and RZ
jobs and nowhere in `.github/workflows/`. Looking at only one of the two
locations makes it easy to wrongly conclude that an `#ifdef`-guarded code
path has no coverage.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Comment thread AGENTS.md Outdated
Co-authored-by: Remi Lehe <remi.lehe@normalesup.org>
Comment thread AGENTS.md Outdated
@RemiLehe
RemiLehe requested a review from ax3l September 2, 2026 18:48
GPU tests live in a third place: `.gitlab/ci.yaml`, run on the HPSF Frank
cluster through a GitHub-to-GitLab mirror rather than as a GitHub Actions
workflow. Every `runs-on:` in `.github/workflows/` is a stock GitHub-hosted
image, so `cuda.yml` / `hip.yml` / `intel.yml` only compile; nothing there
executes on a GPU.

Worth noting that it is label-gated (`bot: run GPU`), so it does not appear
in a default PR's checks.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@RemiLehe
RemiLehe requested a review from EZoni September 2, 2026 18:53
@ax3l ax3l self-assigned this Sep 3, 2026
@ax3l ax3l added the component: documentation Docs, readme and manual label Sep 3, 2026

@ax3l ax3l left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! You were right to push back -- .... Classic phrase :D

@ax3l
ax3l merged commit 80d3a5e into BLAST-WarpX:development Sep 3, 2026
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: documentation Docs, readme and manual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants