Fix particle boundary conditions in curvilinear geometries - #7235
Open
JustinRayAngus wants to merge 10 commits into
Open
Fix particle boundary conditions in curvilinear geometries#7235JustinRayAngus wants to merge 10 commits into
JustinRayAngus wants to merge 10 commits into
Conversation
dpgrote
reviewed
Sep 2, 2026
dpgrote
reviewed
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds helper routines for transforming a particle’s momentum between Cartesian coordinates and the local curvilinear basis. Before calling
ApplyParticleBoundaries::apply_boundaries(), particle momentum is transformed into the curvilinear basis and then transformed back to Cartesian coordinates afterward. This simplifies the logic inapply_boundaries()and fixes several bugs and oversights in particle boundary handling for RZ, RCYLINDER, and RSPHERE geometries.Issues fixed in this PR for curvilinear geometries:
thermalize_boundary_particles()at radial (x) boundaries