WarnManager.cpp: simplify an expression using std::format (C++20 feature) - #7230
Closed
lucafedeli88 wants to merge 1 commit into
Closed
WarnManager.cpp: simplify an expression using std::format (C++20 feature)#7230lucafedeli88 wants to merge 1 commit into
lucafedeli88 wants to merge 1 commit into
Conversation
Member
Author
|
I am closing this, because one of the compiler combinations that we want to support ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C++20 has introduced a [text formatting library](see https://en.cppreference.com/cpp/utility/format) that greatly simplifies certain expressions.
This PR exemplifies this new feature by changing the expression :
into
I've verified that, after this substitution, the warning logger produces a text message identical to the one of the test presented here: https://warpx.readthedocs.io/en/latest/developers/warning_logger.html .
If no issues are reported, I would like to expand the usage of
std::formatin WarpX.