append to dt_updates. - #7226
Merged
JustinRayAngus merged 2 commits intoAug 31, 2026
Merged
Conversation
lucafedeli88
approved these changes
Aug 31, 2026
lucafedeli88
left a comment
lucafedeli88
left a comment
Member
There was a problem hiding this comment.
It looks good to me. Thanks !
dpgrote
reviewed
Aug 31, 2026
| file_mode = std::ofstream::out | std::ofstream::app; | ||
| } | ||
|
|
||
| std::ofstream diagnostic_file{m_dt_update_diagnostic_file, file_mode}; |
Member
There was a problem hiding this comment.
This could be simplified more. The file doesn't need to be opened in a restart since nothing needs to be written here. Note that the create_directories should still be done in case the user deleted it or is running in a different space than the original run.
if (IsNotRestart) {
std::ofstream diagnostic_file{m_dt_update_diagnostic_file, std::ofstream::out | std::ofstream::trunc);
int c = 0;
diagnostic_file << "#";
...
diagnostic_file.close();
}
JustinRayAngus
enabled auto-merge (squash)
August 31, 2026 18:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug from PR #7221 that results in the dt_updates file being overwritten on a restart.