You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The calculation of the global Debye length during binary collisions was added in PR #5763. It was recently realized that the access was being done incorrectly, not taking into account that the MFIter loop was using tiling. With tiling, the i_cell index is relative to the tile and cannot be directly used to access MultiFab data. The fix is to use the global_index that was add in PR #6954.
Note that this error was not detected since the CI test does not use tiling.
Note that this error was not detected since the CI test uses a domain uniformly filled with plasma so accessing the global Debye length data at the wrong cell index did not have a significant effect on the results since it will also be uniform.
By chance, do you know if there is an easy way to modify the CI test such that the plasma doesn't fill the domain uniformly (so as to catch bugs like the one fixed in this PR going forward)?
Note that this error was not detected since the CI test uses a domain uniformly filled with plasma so accessing the global Debye length data at the wrong cell index did not have a significant effect on the results since it will also be uniform.
By chance, do you know if there is an easy way to modify the CI test such that the plasma doesn't fill the domain uniformly (so as to catch bugs like the one fixed in this PR going forward)?
@EZoni The test could be added, but would require somewhat significant change to the existing test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The calculation of the global Debye length during binary collisions was added in PR #5763. It was recently realized that the access was being done incorrectly, not taking into account that the MFIter loop was using tiling. With tiling, the
i_cellindex is relative to the tile and cannot be directly used to access MultiFab data. The fix is to use theglobal_indexthat was add in PR #6954.Note that this error was not detected since the CI test does not use tiling.