Remove unused GMRES option in curl-curl MLMG preconditioner - #7216
Merged
JustinRayAngus merged 1 commit intoAug 28, 2026
Merged
Conversation
The curl-curl preconditioner had an undocumented option to use GMRES (optionally preconditioned by MLMG) instead of MLMG directly, i.e. GMRES as a preconditioner inside the outer GMRES solver. This was never used in practice and was not documented, so remove it along with the parsing of pc_curl_curl_mlmg.use_gmres and pc_curl_curl_mlmg.use_gmres_pc. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
debog
approved these changes
Aug 28, 2026
JustinRayAngus
approved these changes
Aug 28, 2026
ax3l
added
component: implicit solvers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The curl-curl preconditioner had an undocumented option to use GMRES (optionally preconditioned by MLMG) instead of MLMG directly, i.e. GMRES as a preconditioner inside the outer GMRES solver. This was never used in practice and was not documented, so remove it along with the parsing of
pc_curl_curl_mlmg.use_gmresandpc_curl_curl_mlmg.use_gmres_pc.