Update Dane (LC) setup scripts - #7212
Merged
dpgrote merged 7 commits intoAug 28, 2026
Merged
Conversation
ax3l
self-requested a review
August 28, 2026 20:21
ax3l
added
component: documentation
ax3l
reviewed
Aug 28, 2026
ax3l
reviewed
Aug 28, 2026
ax3l
reviewed
Aug 28, 2026
ax3l
reviewed
Aug 28, 2026
Comment on lines
+129
to
+134
| EXPECTED_VENV="${WARPX_SW_DIR}/venvs/warpx-dane" | ||
| if [[ -n "${VIRTUAL_ENV:-}" && | ||
| "$(realpath "$VIRTUAL_ENV")" == "$(realpath "$EXPECTED_VENV")" ]]; then | ||
| # If it is activated | ||
| deactivate | ||
| fi |
Member
There was a problem hiding this comment.
Complicated and appears redundant to lines 30ff.:
# Make sure that a virtual environment is not already activated
if declare -F deactivate &>/dev/null; then
deactivate
fi
Member
Author
There was a problem hiding this comment.
I was seeing odd errors at this point when testing this script and running it multiple times. The script was acting like the virtual environment was still activated. After it removed the warpx-dane venv it couldn't find python3. Doing the deactivate here seemed to fix it. But I agree this is redundant so removed it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the setup scripts on dane (at LLNL) to use the latest version of the modules. It also now includes the optional build of PETSC. Some other cleanup was done.