Minor fixes in CODE_OF_CONDUCT.md, CONTRIBUTING.md - #7211
Merged
Conversation
| #### Include a test in your PR | ||
|
|
||
| A new feature is great, a **working** new feature is even better! | ||
| Please test your code and add your test to the automated test suite. |
Member
There was a problem hiding this comment.
Maybe we could add something here to explain better when new tests are actually required. Certainly they are required for a completely new feature. Otherwise, expanding existing tests may be a better option.
lucafedeli88
approved these changes
Aug 28, 2026
lucafedeli88
left a comment
lucafedeli88
left a comment
Member
There was a problem hiding this comment.
Thanks, @EZoni .
I've left a minor comment, but it can be also accepted as it is.
Member
Author
|
Thanks, @lucafedeli88! Yes, this PR was just to include some minor fixes left out of #7203. On the tests topic, I added an agenda item to next week's developers meeting and I think we can take care of that in a separate PR, after we come to an agreement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Minor fixes (typos, style) originally flagged in #7203, but later excluded from that PR to keep it focused.