Skip to content

Generalize default test analysis scripts (regression, restart) - #7197

Merged
EZoni merged 5 commits into
BLAST-WarpX:developmentfrom
dpgrote:add_options_to_analysis_default_restart
Aug 27, 2026
Merged

Generalize default test analysis scripts (regression, restart)#7197
EZoni merged 5 commits into
BLAST-WarpX:developmentfrom
dpgrote:add_options_to_analysis_default_restart

Conversation

@dpgrote

@dpgrote dpgrote commented Aug 26, 2026

Copy link
Copy Markdown
Member

Does some clean up of analysis_default_restart.py. Added rtol input option. This option is needed in PR #6954.

@dpgrote
dpgrote requested a review from EZoni August 26, 2026 16:35
Comment thread Examples/analysis_default_restart.py
@EZoni

EZoni commented Aug 26, 2026

Copy link
Copy Markdown
Member

Also, should we take care of your comment #6954 (comment) as well, since we're at it?

An aside, analysis_default_restart.py uses dr = ad_restart[field].squeeze().v. To be fully correct, this should be dr = ad_restart["boxlib", field].squeeze().v.

EZoni
EZoni previously approved these changes Aug 26, 2026
@EZoni
EZoni dismissed their stale review August 26, 2026 20:24

More changes needed.

Comment thread Examples/analysis_default_restart.py
Comment thread Examples/analysis_default_restart.py Outdated
Comment thread Examples/analysis_default_restart.py Outdated
@ax3l ax3l added the component: checkpoint/restart Checkpointing & restarts label Aug 26, 2026
Comment thread Examples/analysis_default_regression.py Outdated
@EZoni

EZoni commented Aug 26, 2026

Copy link
Copy Markdown
Member

pre-commit.ci - pr is failing due to "timeout waiting for merge ref", so I think it's not related to the changes in this PR.

@EZoni EZoni changed the title Generalize analysis_default_restart.py Generalize default test analysis scripts (regression, restart) Aug 26, 2026
@dpgrote dpgrote closed this Aug 27, 2026
@dpgrote dpgrote reopened this Aug 27, 2026
@EZoni
EZoni enabled auto-merge (squash) August 27, 2026 05:48
@EZoni
EZoni merged commit 05a7621 into BLAST-WarpX:development Aug 27, 2026
94 checks passed
@dpgrote
dpgrote deleted the add_options_to_analysis_default_restart branch August 27, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: checkpoint/restart Checkpointing & restarts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants