Linear Breit-Wheeler: use amrex::Math::powi and _prt literals - #7191
Merged
Conversation
EZoni
added
cleaning
Member
Author
|
Do you see any floating point precision issue that I may be overlooking with these changes? |
WeiqunZhang
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small refactor of the linear Breit-Wheeler cross-section and utility headers split from #6141, to keep that PR as focused as possible.
Replaces the local
pow2/pow4lambdas withamrex::Math::powi<N>, and the auxiliaryone_half_pr/one_prconstants with the0.5_prt/1._prtliterals.There should be no change in behavior and no benchmark updates.