Guide 6: exercise ws.license in the executed cells - #328
Merged
Conversation
The Stage 4 markdown has taught ws.license since the license work merged, but the code cell never called it. Add the call, let the Stage 5 Zenodo cell inherit the workspace default instead of passing license= explicitly (matching the documented precedence), and re-execute the notebook so the committed outputs show the license stamp.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the ws.license("cc-by-4.0") call to Guide 6's Stage 4 code cell, removes the now-redundant explicit license= from the guarded Stage 5 ws.zenodo call so the deposit demonstrates workspace-default inheritance, and re-executes the notebook so committed outputs are real.
Why
The license documentation landed in the Stage 4/5 markdown while ws.license was still unmerged, so the code cells lagged the prose: records in the executed walkthrough saved without a license and the Zenodo cell contradicted the stated precedence. This was the declared follow-up from the quickstart-truth PR.
How
Two cell edits plus a full nbconvert re-execution in the uv --all-extras environment; no markdown changes.
Testing
Notebook re-executed end to end offline; Stage 4 output now shows the workspace license stamp. uv run pytest -k "notebook or snippet": 10 passed.