Fix BCU-console hanging on Console.ReadKey() after showing help

[hazeliscoding]

Fixes #956

BCU-console help / /? called Console.ReadKey() after printing help, which blocked interactive shells and threw InvalidOperationException when console input was redirected (pipes, CI, Task Scheduler).

This removes the Console.ReadKey() call so help prints and exits 0 immediately.

[Klocman]

This is done deliberately since the target audience are Windows users that are likely to double click the exe and wonder what happened. As far as I could see there was no way to detect if the app was ran in a shell or standalone.

What exactly is the use of running the help command in a script?

[hazeliscoding]

This is done deliberately since the target audience are Windows users that are likely to double click the exe and wonder what happened. As far as I could see there was no way to detect if the app was ran in a shell or standalone.

What exactly is the use of running the help command in a script?

I can update the PR to skip the pause when input is redirected and only pause when the app owns the console (GetConsoleProcessList() == 1). That keeps the window open for double-click users without adding an extra prompt for shell users.

[Klocman]

I can update the PR to skip the pause when input is redirected and only pause when the app owns the console (GetConsoleProcessList() == 1). That keeps the window open for double-click users without adding an extra prompt for shell users.

This would work, yeah.