Skip to content

fix: tap mapped to gamepad button not firing - #28

Merged
BANANASJIM merged 1 commit into
mainfrom
fix/tap-gamepad-button
Mar 13, 2026
Merged

fix: tap mapped to gamepad button not firing#28
BANANASJIM merged 1 commit into
mainfrom
fix/tap-gamepad-button

Conversation

@BANANASJIM

Copy link
Copy Markdown
Owner

Summary

  • Fix gamepad button taps being invisible to state-polling applications (SDL, XInput)
  • Replace synchronous press+release in emit_tap with the existing injected_buttons_/injected_ext_ injection mechanism so the button persists for one full HID poll period

Closes #25

Synchronous press+release in emit_tap was invisible to state-polling
applications (SDL, XInput). Use injected_buttons_/injected_ext_ so
the button persists for one full HID poll period.

Closes #25
@coderabbitai

coderabbitai Bot commented Mar 13, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@BANANASJIM has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 15 minutes and 0 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4153c77c-f511-4f16-a260-47b525a7bed7

📥 Commits

Reviewing files that changed from the base of the PR and between 53e123a and a179358.

📒 Files selected for processing (1)
  • src/gamepad.cpp
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/tap-gamepad-button
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@BANANASJIM
BANANASJIM marked this pull request as ready for review March 13, 2026 21:15
@BANANASJIM
BANANASJIM merged commit 5a348e6 into main Mar 13, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tap mapped to a controller button does not work

1 participant