Add draft Sign Up V2 end-to-end tests (skipped pending test slice) - #3094
Draft
Sergei Demchenko (antrix1989) with Copilot wants to merge 2 commits into
Draft
Add draft Sign Up V2 end-to-end tests (skipped pending test slice)#3094Sergei Demchenko (antrix1989) with Copilot wants to merge 2 commits into
Sergei Demchenko (antrix1989) with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: antrix1989 <1989385+antrix1989@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement draft Sign Up V2 end-to-end tests
Add draft Sign Up V2 end-to-end tests (skipped pending test slice)
Aug 28, 2026
| @@ -178,6 +178,9 @@ | |||
| 230967422711156A001B42D9 /* MSALTestsConfig.m in Sources */ = {isa = PBXBuildFile; fileRef = 230967402711156A001B42D9 /* MSALTestsConfig.m */; }; | |||
There was a problem hiding this comment.
This pull request does not update CHANGELOG.md.
Please consider if this change would be noticeable to a partner or user and either update CHANGELOG.md or resolve this conversation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V1 Sign Up E2E coverage had no V2 (server-driven) equivalent for the sign-up flow introduced in PR #3093. This adds the missing suites without duplicating or modifying the production Sign Up V2 logic.
Dependency: stacked on
spetrescu/native-auth-v2-signup(PR #3093). Retarget todevonce #3093 merges.New test suites
MSALNativeAuthSignUpUsernameV2EndToEndTests.swift— ports all 10 scenarios from V1'sMSALNativeAuthSignUpUsernameEndToEndTestsontosignUpV2(parameters:delegate:)/MSALNativeAuthSignUpParametersV2and the unified V2 state machine (MSALNativeAuthCodeRequiredState,AttributesRequiredState/AttributesInvalidState,SignInAfterSignUpState).MSALNativeAuthSignUpUsernameAndPasswordV2EndToEndTests.swift— ports all 12 scenarios from V1'sMSALNativeAuthSignUpUsernameAndPasswordEndToEndTests.SignUpDelegateSpiesV2.swift— newSignUpV2DelegateSpyconforming to the unifiedMSALNativeAuthFlowDelegatefamily (CodeRequired,AttributesRequired,AttributesInvalid,SignInAfterSignUpRequired), matching the existingSignInV2DelegateSpypattern.Coverage gaps
4 username+password scenarios (
...FirstStepAndThenSetPassword...,...andSetPasswordAfterOTP_success,...FirstStepAndCustomAttributes...,...FirstStepAndCustomAttributesOverMultipleScreens...) rely on a post-OTP "set password after verification" step that Sign Up V2 doesn't currently expose. These are kept and marked with// NOTE:comments, adapted to submit the password up front instead — resend-OTP, custom-attribute, and multi-screen coverage is preserved.Execution
All tests are skipped via:
Sign Up V2 requires a test slice not yet available, so nothing here executes; code was verified to compile against the real V2 API surface.
Project registration
MSAL.xcodeproj/project.pbxprojupdated to register the new files under the same group/targets as the V1 sign-up files.Original prompt