-
Notifications
You must be signed in to change notification settings - Fork 162
Implement SMS method selection for SSPR v2 #3092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
6
commits into
dev
Choose a base branch
from
copilot/sspr-v2-sms-method-selection
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+837
−26
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0c9eef8
Initial plan
Copilot af20903
Add SSPR v2 SMS method selection
Copilot 90d5e5a
Handle invalid SSPR method links
Copilot 676c055
Address method selection review feedback
Copilot 6084d7e
Clean up auth method selection API
Copilot 4ed6eb3
Reject malformed auth method challenge links
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These object ids are hand-minted placeholders (
0AA10000000000000000AA01…AA04,…AF01/AF02) rather than the random 24-hex ids Xcode generates. Two practical problems:0AA10000…lands between01462653…and01F6FDA4…in every section. Xcode re-sorts on the next project save, so whoever next opens the project in the IDE will produce an unrelated reshuffle diff.Please regenerate these by adding the files through Xcode (or with random hex) so the ids and ordering match the rest of the file.