Update MDM notification default delay - #1939
Open
Swasti Gupta (swasti29) with Copilot wants to merge 2 commits into
Open
Update MDM notification default delay#1939Swasti Gupta (swasti29) with Copilot wants to merge 2 commits into
Swasti Gupta (swasti29) with Copilot wants to merge 2 commits into
Conversation
Co-authored-by: swasti29 <12692041+swasti29@users.noreply.github.com>
Copilot
AI
changed the title
Update MDM profile installed notification default delay
Update MDM notification default delay
Aug 15, 2026
Copilot created this pull request from a session on behalf of
Swasti Gupta (swasti29)
August 15, 2026 08:08
View session
Swasti Gupta (swasti29)
marked this pull request as ready for review
August 15, 2026 08:09
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates IdentityCore’s default delay used when scheduling the “MDM profile installed” reminder notification prior to the profile-download ASWebAuthenticationSession hand-off, and adjusts unit coverage to validate the new default.
Changes:
- Updated
MSIDMDMProfileInstalledNotificationDefaultDelayfrom75.0to45.0seconds. - Added a unit-test assertion to verify the constant’s default value is
45.0when scheduling the notification.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| IdentityCore/src/MSIDConstants.m | Changes the default MDM profile-installed notification delay constant to 45 seconds. |
| IdentityCore/tests/MSIDWebviewNavigationHandlerTests.m | Adds an assertion to ensure the default delay constant is 45.0, strengthening coverage for scheduling behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: swasti29 <12692041+swasti29@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MDM profile-installed notification delay default needs to change from 75 seconds to 45 seconds. Related unit coverage should verify the new default.
Default delay
MSIDMDMProfileInstalledNotificationDefaultDelayto 45 seconds.Unit coverage
45.0when scheduling the MDM profile-installed notification.