Skip to content

Update MDM notification default delay - #1939

Open
Swasti Gupta (swasti29) with Copilot wants to merge 2 commits into
devfrom
copilot/update-notification-delay-value
Open

Update MDM notification default delay#1939
Swasti Gupta (swasti29) with Copilot wants to merge 2 commits into
devfrom
copilot/update-notification-delay-value

Conversation

Copilot AI commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

The MDM profile-installed notification delay default needs to change from 75 seconds to 45 seconds. Related unit coverage should verify the new default.

  • Default delay

    • Updated MSIDMDMProfileInstalledNotificationDefaultDelay to 45 seconds.
  • Unit coverage

    • Added an assertion that the default delay constant is 45.0 when scheduling the MDM profile-installed notification.
NSTimeInterval const MSIDMDMProfileInstalledNotificationDefaultDelay = 45.0;

Co-authored-by: swasti29 <12692041+swasti29@users.noreply.github.com>
Copilot AI changed the title Update MDM profile installed notification default delay Update MDM notification default delay Aug 15, 2026
@swasti29
Swasti Gupta (swasti29) marked this pull request as ready for review August 15, 2026 08:09
Copilot AI lite review requested due to automatic review settings August 15, 2026 08:09
@swasti29
Swasti Gupta (swasti29) requested a review from a team as a code owner August 15, 2026 08:09
Comment thread IdentityCore/src/MSIDConstants.m

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates IdentityCore’s default delay used when scheduling the “MDM profile installed” reminder notification prior to the profile-download ASWebAuthenticationSession hand-off, and adjusts unit coverage to validate the new default.

Changes:

  • Updated MSIDMDMProfileInstalledNotificationDefaultDelay from 75.0 to 45.0 seconds.
  • Added a unit-test assertion to verify the constant’s default value is 45.0 when scheduling the notification.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
IdentityCore/src/MSIDConstants.m Changes the default MDM profile-installed notification delay constant to 45 seconds.
IdentityCore/tests/MSIDWebviewNavigationHandlerTests.m Adds an assertion to ensure the default delay constant is 45.0, strengthening coverage for scheduling behavior.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Co-authored-by: swasti29 <12692041+swasti29@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants