Skip to content

Full edge to edge support - #2721

Merged
Dome Pongmongkol (rpdome) merged 4 commits into
devfrom
rapong/edge2edge
Jul 30, 2025
Merged

Full edge to edge support#2721
Dome Pongmongkol (rpdome) merged 4 commits into
devfrom
rapong/edge2edge

Conversation

@rpdome

@rpdome Dome Pongmongkol (rpdome) commented Jul 29, 2025 •
edited by azure-boards Bot
Loading

Copy link
Copy Markdown
Member

AB#3129177

image image

@rpdome
Dome Pongmongkol (rpdome) requested a review from a team as a code owner July 29, 2025 00:34
@github-actions

github-actions Bot commented Jul 29, 2025

Copy link
Copy Markdown

✅ Work item link check complete. Description contains link AB#3129177 to an Azure Boards work item.

@rpdome
Dome Pongmongkol (rpdome) requested a review from a team as a code owner July 29, 2025 00:37
@github-actions

github-actions Bot commented Jul 29, 2025

Copy link
Copy Markdown

✅ Work item link check complete. Description contains link AB#3129177 to an Azure Boards work item.

rpdome
Dome Pongmongkol (rpdome) commented Jul 29, 2025
View reviewed changes
Comment thread common/build.gradle

implementation 'org.apache.httpcomponents.core5:httpcore5:5.3'
implementation "com.nimbusds:nimbus-jose-jwt:$rootProject.ext.nimbusVersion"
implementation "androidx.activity:activity:1.8.2"

@rpdome Dome Pongmongkol (rpdome) Jul 29, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

picked 1.8.2 as suggested by Nick Bopp (@nickbopp)
Pull request 4266808: Downgrade required androidx.activity version to 1.8 - Repos

@rpdome
Dome Pongmongkol (rpdome) force-pushed the rapong/sdk35 branch 2 times, most recently from b13fc75 to 302409b Compare July 29, 2025 17:03
@github-actions

github-actions Bot commented Jul 29, 2025

Copy link
Copy Markdown

✅ Work item link check complete. Description contains link AB#3129177 to an Azure Boards work item.

mohitc1
Mohit (mohitc1) previously approved these changes Jul 29, 2025
View reviewed changes

@mohitc1 Mohit (mohitc1) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Base automatically changed from rapong/sdk35 to dev July 30, 2025 18:31
@rpdome
Dome Pongmongkol (rpdome) dismissed Mohit (mohitc1)’s stale review July 30, 2025 18:31

The base branch was changed.

Copilot AI review requested due to automatic review settings July 30, 2025 18:32
Copilot AI reviewed Jul 30, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements full edge-to-edge support for Android UI by enabling edge-to-edge rendering by default and properly handling system insets to prevent UI overlap with system bars and other UI elements.

  • Enables the edge-to-edge flight by default
  • Implements proper inset handling for system bars, display cutouts, gestures, and keyboard
  • Adds androidx.activity dependency for EdgeToEdge support

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
CommonFlight.java Enables edge-to-edge handling flight by default
DualScreenActivity.java Implements edge-to-edge rendering with proper inset handling and light theme
build.gradle Adds androidx.activity dependency for EdgeToEdge functionality
changelog.txt Documents the new edge-to-edge support feature

Comment thread common/src/main/java/com/microsoft/identity/common/internal/ui/DualScreenActivity.java Outdated
Comment thread common/src/main/java/com/microsoft/identity/common/internal/ui/DualScreenActivity.java Outdated
Comment thread common/src/main/java/com/microsoft/identity/common/internal/ui/DualScreenActivity.java Outdated
@github-actions

github-actions Bot commented Jul 30, 2025

Copy link
Copy Markdown

✅ Work item link check complete. Description contains link AB#3129177 to an Azure Boards work item.

Dome Pongmongkol (rpdome) and others added 2 commits July 30, 2025 12:03
@rpdome
Update common/src/main/java/com/microsoft/identity/common/internal/ui…
e06d5a0 
…/DualScreenActivity.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@rpdome
Update common/src/main/java/com/microsoft/identity/common/internal/ui…
3e31778 
…/DualScreenActivity.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
mohitc1
Mohit (mohitc1) approved these changes Jul 30, 2025
View reviewed changes

@mohitc1 Mohit (mohitc1) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@github-actions

github-actions Bot commented Jul 30, 2025

Copy link
Copy Markdown

✅ Work item link check complete. Description contains link AB#3129177 to an Azure Boards work item.

@rpdome
Dome Pongmongkol (rpdome) merged commit b186398 into dev Jul 30, 2025
49 of 54 checks passed
@rpdome
Dome Pongmongkol (rpdome) deleted the rapong/edge2edge branch July 30, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@mohitc1 Mohit (mohitc1) mohitc1 approved these changes
@melissaahn melissaahn melissaahn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rpdome @mohitc1 @melissaahn