Skip to content

ci: remove max-parallel: 3 so one approval covers the whole matrix #1270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LeonardCareer merged 1 commit into from
Jul 28, 2026
Merged

ci: remove max-parallel: 3 so one approval covers the whole matrix #1270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 1 addition & 12 deletions .github/workflows/terraform-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,7 @@ env:
TERRAFORM_AWS_MODULES_DIR: modules/terraform/aws

jobs:
authorize:
environment: terraform-privileged
runs-on: ubuntu-latest
steps:
- name: Authorized
run: 'echo "Authorized PR ${{ github.event.pull_request.number }} head=${{ github.event.pull_request.head.sha }}"'

terraform-test:
needs: authorize
environment: terraform-privileged
permissions:
contents: read
Expand All @@ -37,7 +29,6 @@ jobs:
- name: Checkout PR head
uses: actions/checkout@v4
with:
# Only checked out AFTER `authorize` completes.
repository: ${{ github.event.pull_request.head.repo.full_name }}
ref: ${{ github.event.pull_request.head.sha }}
persist-credentials: false
Expand Down Expand Up @@ -69,7 +60,6 @@ jobs:
ARM_SUBSCRIPTION_ID: ${{ secrets.AZURE_SUBSCRIPTION_ID }}

setup-matrix:
needs: authorize
runs-on: ubuntu-latest
name: Setup terraform plan matrix for test scenarios
steps:
Expand Down Expand Up @@ -130,15 +120,14 @@ jobs:
matrix-combinations: ${{ steps.setup-matrix-scenarios.outputs.matrix_combinations }}

terraform-plan:
needs: [authorize, setup-matrix]
needs: setup-matrix
environment: terraform-privileged
permissions:
id-token: write
contents: read
if: ${{ needs.setup-matrix.result == 'success' && needs.setup-matrix.outputs.matrix-combinations != '' && needs.setup-matrix.outputs.matrix-combinations != 'null' }}
strategy:
fail-fast: false
max-parallel: 3
matrix: ${{ fromJson(needs.setup-matrix.outputs.matrix-combinations) }}
runs-on: ubuntu-latest
name: ${{ matrix.cloud }}-${{ matrix.scenario_type }}-${{ matrix.scenario_name }} ${{ matrix.region }}
Expand Down
Loading