[code sync] Merge code from sonic-net/sonic-utilities:202605 to 202607 - #429
Merged
Conversation
mssonicbld
commented
Aug 7, 2026
mssonicbld
commented
Collaborator
<!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md CODE_OF_CONDUCT.md LICENSE README.md SECURITY.md SUPPORT.md azure-pipelines failure_prs.log scripts skip_prs.log Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "closes #xxxx", "fixes #xxxx" or "resolves #xxxx" so that GitHub automatically closes the related issue when the PR is merged. If you are adding/modifying/removing any command or utility script, please also make sure to add/modify/remove any unit tests from the tests directory as appropriate. If you are modifying or removing an existing 'show', 'config' or 'sonic-clear' subcommand, or you are adding a new subcommand, please make sure you also update the Command Line Reference Guide (doc/Command-Reference.md) to reflect your changes. Please provide the following information: --> #### What I did The BMC support check in `generate_dump` was aligned with the new infrastructure flow (sonic-net/sonic-buildimage#26544). Instead of checking for platform-local `bmc.json` assumptions, the logic now validates host-side role and runtime BMC data from the canonical source used by the system. #### How I did it - Updated `generate_dump` BMC detection to use `device_info.is_switch_host()` together with `device_info.get_bmc_data()`. - Removed reliance on legacy platform-folder `bmc.json` existence behavior for this path. - Kept the `generate_dump` flow behavior intact while aligning detection to runtime `/etc/sonic/bmc.json`-based APIs. #### How to verify it - Run `show techsupport` (or `generate_dump`) on: - a switch-host platform with valid BMC data and verify BMC-related flow executes. - a non-switch-host / missing-BMC-data platform and verify BMC path is skipped. Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com> #### Previous command output (if the output of a command-line utility has changed) #### New command output (if the output of a command-line utility has changed)
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.