Skip to content

[Cherry-pick] [26777] [acl]: Exclude PortChannel members from LT2 ACL bindings #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bingwang-ms merged 1 commit into from
Aug 5, 2026
Merged

[Cherry-pick] [26777] [acl]: Exclude PortChannel members from LT2 ACL bindings #1345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions tests/acl/test_acl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,9 +517,15 @@ def setup(duthosts, ptfhost, rand_selected_dut, rand_selected_front_end_dut, ran
# For LT2, add portchannels for downstream links
for k, v in list(port_channels.items()):
acl_table_ports[v['namespace']].append(k)
# Add RIF for upstream links
# Add standalone RIFs for upstream links. PortChannel members cannot
# also be bound to the ACL table as physical interfaces.
pc_members = defaultdict(set)
for pc in port_channels.values():
pc_members[pc['namespace']].update(pc.get('members', []))
for namespace, port in list(upstream_ports.items()):
acl_table_ports[namespace] += port
acl_table_ports[namespace] += [
interface for interface in port if interface not in pc_members[namespace]
]
else:
for namespace, port in list(upstream_ports.items()):
acl_table_ports[namespace] += port
Expand Down