[action] [PR:28518] [nexthop] watchdog implementation: temporary workaround to arm 2 watchdogs - #2883
Merged
Conversation
…hdogs #### Why I did it This is a temporary workaround to arm hardware watchdog that triggers power cycle. The workaround is needed until full SW support of both watchdog 1 and 2. Also updates the arm value to 300 seconds as this is what [platform_tests /test_hw_watchdog.py](https://github.com/sonic-net/sonic-mgmt/blob/7a73917c813d20b62e72e47a15d9c4825fe8c2f8/tests/platform_tests/test_hw_watchdog.py#L90) expects ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it Arm watchdog 2 by writing to `0x1d8` register before arming watchdog 1. #### How to verify it Arm watchdog using `watchdogutil`. sonic-mgmt test `tests/platform_tests/api/test_watchdog.py` #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 - [x] 202511 - [x] 202512 - [x] 202605 - [ ] 202608 Tracking issue/work item for backport/cherry-pick request (GitHub issue or Microsoft ADO): Failure type: <!-- day-one issue / regression / other --> #### Tested branch <!-- - Select each branch where the change was tested. - If you request a backport/cherry-pick, select the base branch and the tested target release branch(es). --> - [x] master - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 - [x] 202511 - [x] 202512 - [x] 202605 - [ ] 202608 - [ ] N/A #### Test result ``` sudo watchdogutil status sudo watchdogutil arm -s 10 sudo watchdogutil status sudo watchdogutil disarm ``` #### Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: --> <!-- Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU. --> #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com> #### A picture of a cute animal (not mandatory but encouraged)
Collaborator
Author
|
Original PR: sonic-net/sonic-buildimage#28518 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
20 tasks
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
This is a temporary workaround to arm hardware watchdog that triggers power cycle. The workaround is needed until full SW support of both watchdog 1 and 2.
Also updates the arm value to 300 seconds as this is what platform_tests
/test_hw_watchdog.py expects
Work item tracking
How I did it
Arm watchdog 2 by writing to
0x1d8register before arming watchdog 1.How to verify it
Arm watchdog using
watchdogutil. sonic-mgmt testtests/platform_tests/api/test_watchdog.pyWhich release branch to backport (provide reason below if selected)
Tracking issue/work item for backport/cherry-pick request (GitHub issue or Microsoft ADO):
Failure type:
Tested branch
Test result
Description for the changelog
Link to config_db schema for YANG module changes
Signed-off-by: Sonic Build Admin sonicbld@microsoft.com
A picture of a cute animal (not mandatory but encouraged)