Skip to content

42 - Adding the new method for returning the proxy connection details as encrypted byte array#51

Open
SivaTharun wants to merge 3 commits into
Azure:masterfrom
SivaTharun:master
Open

42 - Adding the new method for returning the proxy connection details as encrypted byte array#51
SivaTharun wants to merge 3 commits into
Azure:masterfrom
SivaTharun:master

Conversation

@SivaTharun

@SivaTharun SivaTharun commented Jun 13, 2021

Copy link
Copy Markdown
Contributor

Overview

Fixes #42 , adding the new method for returning the proxy connection details as encrypted byte array

Notes

  • added ProxyHandler.createProxyRequestStream method to address the problem described, that returns proxy connection
    details as encrypted byte array
  • added unit test for the above method , to verify the same.

Testing Instructions

  • Run mvn:verify command, to run the tests and check for any checkstyle and spotbugs issues.

- added the createProxyRequestStream to support the describe d operation
- added unit test for the newly added method
@SivaTharun SivaTharun changed the title 42 - 42 - Adding the new method for returning the proxy connection details as encrypted byte array Jun 13, 2021
@conniey conniey self-assigned this Feb 27, 2025
@conniey

conniey commented Feb 27, 2025

Copy link
Copy Markdown
Member

@SivaTharun Hey,

  1. Can you add import java.nio.charset.StandardCharsets; to ProxyHandlerImpl to fix the CI failure?
  2. Can you update eng/spotbugs/spotbugs-excludes.xml to remove this suppression?

I tried to resolve the issues myself, but I can't push to your branch with the fixes.

Thanks! (Apologies. I realise this PR has been out... a long time.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use ISO-8859-1 to encode proxy requests

2 participants