Mahsaini/kaito nvme support#545
Conversation
| ) | ||
|
|
||
| // EphemeralDiskFilter is a filter for ephemeral disks using default values. | ||
| var EphemeralDiskFilter = NewEphemeralDiskFilter(DefaultDiskPathPrefixes, DefaultDiskModels, DefaultDiskTypes) |
There was a problem hiding this comment.
This is not used anywhere I think.
| // whitespace-only entries are ignored, and an empty category is skipped so it | ||
| // does not filter anything out. | ||
| func NewEphemeralDiskFilter(pathPrefixes, models, types []string) *Filter { | ||
| filters := make([]FilterPredicate, 0, 3) |
There was a problem hiding this comment.
lets append the above defaults to the function args including de-dupe. And we remove these defaults from chart values. So the chart is going to carry the newer moders, paths, types if any. This way the churn comes down
| - --run-alongside-webhook={{ .Values.webhook.hyperconverged.enabled | default false }} | ||
|
|
||
| - --disk-path-prefixes={{ join "," (.Values.diskSelection.pathPrefixes | default (list "/dev/nvme")) }} | ||
| - --disk-models={{ join "," (.Values.diskSelection.models | default (list "Microsoft NVMe Direct Disk" "Microsoft NVMe Direct Disk v2")) }} |
There was a problem hiding this comment.
sync the default list from values.yaml.
| return "", err | ||
| } | ||
| for _, line := range strings.Split(strings.TrimSpace(out), "\n") { | ||
| for line := range strings.SplitSeq(strings.TrimSpace(out), "\n") { |
| "-o", "jsonpath={range .items[*]}{.spec.nodeName}{\"\\n\"}{end}")) | ||
| Expect(err).NotTo(HaveOccurred(), "Failed to list csi-local-node pods") | ||
| for _, line := range strings.Split(strings.TrimSpace(out), "\n") { | ||
| for line := range strings.SplitSeq(strings.TrimSpace(out), "\n") { |
|
@MahashriSaini please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
|
All the Above comments have been addressed in new PR - #549 |
Introduces configurable NVMe model filtering through Helm chart values. A predefined set of supported NVMe disk models is provided as the default configuration, while allowing users to extend or override the model list during installation. The configured models are passed to the driver through a CLI argument and used to construct the filter for disk discovery. This approach improves flexibility and enables support for additional NVMe disk models across cloud environments without requiring driver code changes.
Fixes #529