ci: add zizmor GitHub Actions security scanner to pre-commit#532
Open
jmclong wants to merge 1 commit into
Open
ci: add zizmor GitHub Actions security scanner to pre-commit#532jmclong wants to merge 1 commit into
jmclong wants to merge 1 commit into
Conversation
Add the zizmor-pre-commit hook (v1.26.1) running the strictest "auditor" persona to catch security issues in GitHub Actions workflows and Dependabot config. Clear the pre-existing findings so the hook passes clean: - dependabot.yml: add a 7-day cooldown to every update ecosystem - push workflows (docker-push-template, helm-push-template): drop the redundant workflow-level id-token: write (excessive-permissions); each job already grants its own - document all job-level permissions with explanatory comments - add explicit job names to satisfy anonymous-definition - test-e2e-pr.yml: move github.run_id / github.run_attempt into env vars so they are no longer expanded directly into a run block (template-injection) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR strengthens the repository’s CI and supply-chain hygiene by adding the zizmor GitHub Actions security scanner to pre-commit and aligning workflow/dependabot configuration to satisfy stricter security checks.
Changes:
- Add
zizmor-pre-commit(v1.26.1) with the strictauditorpersona to the pre-commit hook set. - Reduce/clarify GitHub Actions token permissions: remove redundant workflow-level privileges in reusable push workflows and document job-level permissions; add explicit job
name:fields to avoid anonymous job definitions. - Update configs to avoid zizmor findings (Dependabot cooldowns; avoid direct
${{ ... }}expansion inside arun:block in the E2E PR workflow).
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.pre-commit-config.yaml |
Adds the zizmor pre-commit hook configured for strict auditing. |
.github/workflows/test.yml |
Adds an explicit job name to satisfy stricter workflow auditing. |
.github/workflows/test-e2e-pr.yml |
Moves github.run_id / github.run_attempt into env vars before use in run: to avoid template-injection style findings. |
.github/workflows/push-tag.yml |
Documents job-level permissions used when invoking reusable push workflows. |
.github/workflows/lint.yml |
Adds an explicit job name to satisfy stricter workflow auditing. |
.github/workflows/helm-push-template.yml |
Removes workflow-level permissions and documents minimal job-level permissions. |
.github/workflows/helm-build-template.yml |
Adds an explicit job name to satisfy stricter workflow auditing. |
.github/workflows/docker-push-template.yml |
Removes workflow-level permissions and documents minimal job-level permissions for push jobs. |
.github/workflows/docker-build-template.yml |
Adds an explicit job name to satisfy stricter workflow auditing. |
.github/workflows/devskim.yml |
Adds explanatory comments for job-level permissions (least privilege documentation). |
.github/workflows/dependency-review.yml |
Adds an explicit job name to satisfy stricter workflow auditing. |
.github/workflows/codeql.yml |
Adds explanatory comments for job-level permissions (least privilege documentation). |
.github/dependabot.yml |
Adds a 7-day cooldown per ecosystem to reduce update noise and satisfy auditing expectations. |
croomes
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the zizmor-pre-commit hook (v1.26.1) running the strictest "auditor" persona to catch security issues in GitHub Actions workflows and Dependabot config.
Clear the pre-existing findings so the hook passes clean: