feat: update scheduler for capacity-based property scheduling#1223
Merged
Conversation
britaniar
force-pushed
the
schedulerChanges
branch
2 times, most recently
from
November 12, 2025 18:00
d0ca169 to
0b39772
Compare
britaniar
marked this pull request as ready for review
November 12, 2025 18:00
zhiying-lin
reviewed
Nov 13, 2025
zhiying-lin
reviewed
Nov 17, 2025
| return nil, errors.New("test error: mapping does not exist") | ||
| } | ||
|
|
||
| // CreateMockAttributeBasedVMSizeRecommenderServer creates a mock HTTP server for testing AttributeBasedVMSizeRecommenderClient. |
Contributor
There was a problem hiding this comment.
it should be under test/utils folder. This file should be deprecated and we cannot mix the test code and prod code.
https://github.com/Azure/fleet/blob/main/pkg/clients/azure/compute/vmsizerecommenderclient_test.go#L208 Can you also refactor this code too?
Contributor
Author
There was a problem hiding this comment.
I'll deprecate the file on kubefleet in a different PR. I will refactor the code in the vmsizerecommenderclient with my function here.
Contributor
|
Have not reviewed the whole PR, will do after you backport the changes, thanks |
britaniar
force-pushed
the
schedulerChanges
branch
from
November 19, 2025 01:21
0274e87 to
6b5ad97
Compare
zhiying-lin
reviewed
Nov 19, 2025
britaniar
force-pushed
the
schedulerChanges
branch
2 times, most recently
from
November 20, 2025 01:33
ff12634 to
45611b1
Compare
zhiying-lin
previously approved these changes
Nov 20, 2025
britaniar
force-pushed
the
schedulerChanges
branch
from
November 20, 2025 18:22
50af2ba to
e7a8f3f
Compare
Signed-off-by: Britania Rodriguez Reyes <britaniar@microsoft.com>
britaniar
force-pushed
the
schedulerChanges
branch
from
November 20, 2025 18:43
e7a8f3f to
ff749f2
Compare
jwtty
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
I have:
Updated the profile so scheduler can have the option to have a property checker (default is nil).
Update the scheduler plugin to include new property checker
Updated clusterRequirements to work similarly but with added property checker.
Update matches where properties are checked to include a check for capacity.
Run
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer
Currently has the bulk of the code to work so the tests are accurate. Will make smaller once the other two PRs are merged.