fix: add kube-system to the managedresource allowed list#1216
Closed
nwnt wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Nont <nont@duck.com>
nibooy
approved these changes
Oct 28, 2025
| ( | ||
| "system:serviceaccounts:openshift-infra" in request.userInfo.groups | ||
| "system:serviceaccounts:openshift-infra" in request.userInfo.groups || | ||
| "system:serviceaccounts:kube-system" in request.userInfo.groups |
Contributor
There was a problem hiding this comment.
instead of exempt all kube-system group, we should exempt "namespace-controller" instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes: the issue where kube-system service couldn't perform edit actions on managed resources.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer