fix: move managed resource VAP out of CRDinstaller#1202
Merged
Conversation
nwnt
changed the title
jim-minter
previously requested changes
Sep 19, 2025
nwnt
force-pushed
the
vap-lifecycle-management
branch
2 times, most recently
from
September 29, 2025 21:52
88d7c79 to
ccf584e
Compare
added 3 commits
September 29, 2025 16:52
Signed-off-by: Nont <nont@duck.com>
Signed-off-by: Nont <nont@duck.com>
Signed-off-by: Nont <nont@duck.com>
nwnt
force-pushed
the
vap-lifecycle-management
branch
2 times, most recently
from
September 29, 2025 22:29
47ed11d to
129bf0e
Compare
Signed-off-by: Nont <nont@duck.com>
nwnt
force-pushed
the
vap-lifecycle-management
branch
from
September 29, 2025 22:38
129bf0e to
323249f
Compare
Signed-off-by: Nont <nont@duck.com>
jim-minter
reviewed
Sep 30, 2025
jim-minter
reviewed
Sep 30, 2025
Signed-off-by: Nont <nont@duck.com>
nwnt
force-pushed
the
vap-lifecycle-management
branch
from
September 30, 2025 00:35
0e8458c to
6166175
Compare
added 2 commits
September 29, 2025 19:44
Signed-off-by: Nont <nont@duck.com>
Arvindthiru
reviewed
Oct 1, 2025
added 2 commits
October 2, 2025 09:56
Signed-off-by: Nont <nont@duck.com>
Signed-off-by: Nont <nont@duck.com>
Arvindthiru
reviewed
Oct 2, 2025
Arvindthiru
reviewed
Oct 2, 2025
Arvindthiru
reviewed
Oct 2, 2025
Signed-off-by: Nont <nont@duck.com>
Arvindthiru
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Move the managed resource VAP and its binding installation out of CRD installer. They are now installed by the hub and member agents. For hub, they are installed after the hub agent starts and never removed. For member, they are installed during member join and removed during member leave.
Fixes # N/A
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Unit tests and E2E tests.
Special notes for your reviewer