fix: update indentation for custom cert#1189
Merged
Merged
Conversation
nibooy
approved these changes
Sep 9, 2025
Member
|
Good find @MuhammadAliFleet ! Please can we have a unit test that uses go templates with a set of values that causes as many parts of the file as possible to be activated, then validates that the result is yaml parseable, so that we hopefully avoid a mistake like this in the future? ^ is a bit of work to do (suggest you use AI) and I'm OK with it being a follow-up as long as it happens soon. Please create a workitem for that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR fixes indentation in the arc agent deployment for custom cert.
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer