refactor: address comments from the previous VAP PR#1181
Merged
Conversation
Contributor
|
Can we also address,
|
Arvindthiru
reviewed
Sep 3, 2025
Arvindthiru
reviewed
Sep 3, 2025
Arvindthiru
reviewed
Sep 3, 2025
Arvindthiru
reviewed
Sep 3, 2025
nwnt
force-pushed
the
address-vap-comments
branch
2 times, most recently
from
September 10, 2025 22:36
b908570 to
452a860
Compare
britaniar
reviewed
Sep 11, 2025
britaniar
reviewed
Sep 11, 2025
added 3 commits
September 11, 2025 15:51
Signed-off-by: Nont <nont@duck.com>
Signed-off-by: Nont <nont@duck.com>
Signed-off-by: Nont <nont@duck.com>
nwnt
force-pushed
the
address-vap-comments
branch
from
September 11, 2025 20:58
452a860 to
54511c6
Compare
Signed-off-by: Nont <nont@duck.com>
nwnt
force-pushed
the
address-vap-comments
branch
from
September 12, 2025 19:59
54511c6 to
a54993b
Compare
Arvindthiru
reviewed
Sep 12, 2025
nwnt
force-pushed
the
address-vap-comments
branch
from
September 12, 2025 20:57
7e5c95e to
a54993b
Compare
Contributor
|
Can we also fix this existing E2E should use systemMasterUser for update https://github.com/Azure/fleet/blob/main/test/e2e/managed_resource_vap_test.go#L168 |
Arvindthiru
reviewed
Sep 12, 2025
Signed-off-by: Nont <nont@duck.com>
britaniar
previously approved these changes
Sep 15, 2025
Arvindthiru
reviewed
Sep 15, 2025
Arvindthiru
requested changes
Sep 15, 2025
Arvindthiru
left a comment
Arvindthiru
left a comment
Contributor
There was a problem hiding this comment.
Could we also cover an update case in the e2e for a resource from placement.kubernetes-fleet.io ?
Signed-off-by: Nont <nont@duck.com>
Arvindthiru
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Addresses the comments from Ryan in #1179 1179
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Running e2e tests successfully.
Special notes for your reviewer