revert: "feat: add managed resource webhook"#1168
Merged
Merged
Conversation
nwnt
changed the title
nwnt
changed the title
nwnt
force-pushed
the
revert-1152-nwnt/add-managed-resource-webhook
branch
from
August 13, 2025 15:11
fd1482c to
0be3c62
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the previously added managed resource webhook functionality. The change removes the webhook that was designed to validate operations on ARM-managed resources in the fleet management system.
- Removes the managed resource webhook validation logic and associated tests
- Updates webhook configuration to reflect the removal of the managed resource validator
- Makes a function visibility change in the user validation module (capitalizing function name)
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/webhook_test.go | Removes ARM managed resource webhook end-to-end tests and related imports |
| test/e2e/utils_test.go | Removes utility functions for creating and managing test namespaces for managed resources |
| test/e2e/resources_test.go | Removes managed namespace template constant |
| pkg/webhook/webhook_test.go | Updates expected webhook count from 10 to 9 after removal |
| pkg/webhook/webhook.go | Removes managed resource webhook registration and configuration |
| pkg/webhook/validation/uservalidation.go | Changes function name from exported to unexported (IsAdminGroupUserOrWhiteListedUser to isAdminGroupUserOrWhiteListedUser) |
| pkg/webhook/managedresource/managedresource_validating_webhook_test.go | Completely removes the managed resource webhook test file |
| pkg/webhook/managedresource/managedresource_validating_webhook.go | Completely removes the managed resource webhook implementation |
| pkg/webhook/add_handler.go | Removes managed resource webhook registration from initialization |
| namespacedName := types.NamespacedName{Name: req.Name, Namespace: req.Namespace} | ||
| userInfo := req.UserInfo | ||
| if checkCRDGroup(group) && !IsAdminGroupUserOrWhiteListedUser(whiteListedUsers, userInfo) { | ||
| if checkCRDGroup(group) && !isAdminGroupUserOrWhiteListedUser(whiteListedUsers, userInfo) { |
There was a problem hiding this comment.
The function IsAdminGroupUserOrWhiteListedUser was changed to isAdminGroupUserOrWhiteListedUser (unexported), but it's still being called from another function. This creates an inconsistency where the function is now unexported but still used as if it were a public API. Consider whether this function should remain exported or if all callers should be updated to use internal validation logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1152
We're moving to a different implementation on the AKS RP, so I'm reverting this one.