feat: add init container to install fleet CRDs#1141
Merged
Conversation
Arvindthiru
force-pushed
the
CRDInitSideCar
branch
from
May 28, 2025 23:52
4409ec9 to
7509600
Compare
Arvindthiru
force-pushed
the
CRDInitSideCar
branch
from
May 30, 2025 22:39
d1f9080 to
565af68
Compare
Arvindthiru
force-pushed
the
CRDInitSideCar
branch
from
June 9, 2025 03:40
1ef75b2 to
1da8ccf
Compare
Arvindthiru
marked this pull request as ready for review
June 11, 2025 01:37
Arvindthiru
force-pushed
the
CRDInitSideCar
branch
from
June 11, 2025 04:39
344b47f to
0b2de1c
Compare
| } | ||
|
|
||
| // Type assertion to make sure we have a CRD. | ||
| crd, ok := obj.(*apiextensionsv1.CustomResourceDefinition) |
Contributor
There was a problem hiding this comment.
is the GVK returned not enough?
Contributor
Author
There was a problem hiding this comment.
We need to convert obj -> crd to access crd.Name to get object existing on the cluster. We can use check to achieve both (type assertion and get object name)
Contributor
There was a problem hiding this comment.
what's that GVK? is that not always CustomResourceDefinition? or that's the real GVK of that CRD (i.e. crp.kube-fleet.io)?
Contributor
Author
There was a problem hiding this comment.
It's CustomResourceDefinition
Arvindthiru
force-pushed
the
CRDInitSideCar
branch
from
June 12, 2025 23:26
e574c46 to
4c736a0
Compare
Arvindthiru
changed the title
added 19 commits
June 20, 2025 13:28
added 19 commits
June 20, 2025 13:28
Arvindthiru
force-pushed
the
CRDInitSideCar
branch
from
June 20, 2025 20:28
a36cc2b to
9246062
Compare
| } | ||
|
|
||
| // Type assertion to make sure we have a CRD. | ||
| crd, ok := obj.(*apiextensionsv1.CustomResourceDefinition) |
Contributor
There was a problem hiding this comment.
what's that GVK? is that not always CustomResourceDefinition? or that's the real GVK of that CRD (i.e. crp.kube-fleet.io)?
added 2 commits
June 25, 2025 10:26
ryanzhang-oss
approved these changes
Jun 25, 2025
ryanzhang-oss
left a comment
ryanzhang-oss
left a comment
Contributor
There was a problem hiding this comment.
we need to add metrics and alert in the next PR
Arvindthiru
added a commit
to Arvindthiru/fleet-public
that referenced
this pull request
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer