Skip to content

Fix participant system messages with client clock skew - #6085

Merged
mgamis-msft merged 2 commits into
mainfrom
mgamis/fix-latent-clock-skew-for-system-messages
Oct 9, 2026
Merged

mgamis-msft merged 2 commits into
mainfrom
mgamis/fix-latent-clock-skew-for-system-messages

Conversation

@mgamis-msft

@mgamis-msft mgamis-msft commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

What

Fixes missing participant join and leave system messages when the client device clock differs from the ACS SDK clock. The recovery query now uses the participant event timestamp instead of client device time.

Why

Client devices with clock skew are not seeing participant joined system message in the chat thread
Related to this IcM https://portal.microsofticm.com/imp/v5/incidents/details/21000001135358/summary about missing typing indicators also caused by clock skew

How Tested

Tested in locally by applying a 45 second clock skew to receiving device

Before with release validation app when remote participant joins chat thread:
image
After with local deploy when remote participant joins chat thread:
image

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@mgamis-msft
mgamis-msft force-pushed the mgamis/fix-latent-clock-skew-for-system-messages branch from 3b6fe7f to 78c6007 Compare October 7, 2026 18:10
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

📦 CallWithChat bundle size

Bundle Base Size (bytes) Current Size (bytes) Change Delta (bytes)
build.bundle.js 7758336 9229415 ⚠️ increased 1471079
450.bundle.js 4470 4470 ➖ unchanged 0
580.bundle.js 12407938 12407938 ➖ unchanged 0
727.bundle.js 372564 372564 ➖ unchanged 0
82.bundle.js 28177 28155 ⬇️ decreased -22
91.bundle.js 4118 4118 ➖ unchanged 0

Total change: +1436.6 KB ⚠️

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

📦 Chat bundle size

Bundle Base Size (bytes) Current Size (bytes) Change Delta (bytes)
build.bundle.js 1793916 1782419 ⬇️ decreased -11497
398.bundle.js 375829 375829 ➖ unchanged 0
450.bundle.js 4454 4454 ➖ unchanged 0
82.bundle.js 28161 28139 ⬇️ decreased -22
91.bundle.js 4102 4102 ➖ unchanged 0

Total change: -11.2 KB ⬇️

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

📦 Calling bundle size

Bundle Base Size (bytes) Current Size (bytes) Change Delta (bytes)
build.bundle.js 6767681 8250147 ⚠️ increased 1482466
580.bundle.js 12407925 12407925 ➖ unchanged 0

Total change: +1447.7 KB ⚠️

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 29739 / 47381
62.76%
29739 / 47381
62.76%
810 / 1491
54.32%
2394 / 3842
62.31%
Current 29739 / 47567
62.52%
29739 / 47567
62.52%
816 / 1501
54.36%
2438 / 3884
62.77%
Diff 0 / 186
-0.24%
0 / 186
-0.24%
6 / 10
0.04%
44 / 42
0.46%

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 58580 / 95109
61.59%
58580 / 95109
61.59%
1180 / 2709
43.55%
3417 / 5799
58.92%
Current 58687 / 95335
61.55%
58687 / 95335
61.55%
1186 / 2719
43.61%
3466 / 5856
59.18%
Diff 107 / 226
-0.04%
107 / 226
-0.04%
6 / 10
0.06%
49 / 57
0.26%

@mgamis-msft
mgamis-msft enabled auto-merge (squash) October 7, 2026 19:05
@mgamis-msft
mgamis-msft merged commit 7401609 into main Oct 9, 2026
140 of 158 checks passed
@mgamis-msft
mgamis-msft deleted the mgamis/fix-latent-clock-skew-for-system-messages branch October 9, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants