Repository navigation
Fix typing indicator expiration with client clock skew - #6084
Merged
Merged
Conversation
Contributor
@azure/communication-react jest test coverage for stable.
|
Contributor
@azure/communication-react jest test coverage for beta.
|
Contributor
📦 Chat bundle size
Total change: -11.3 KB ⬇️ |
Contributor
📦 CallWithChat bundle size
Total change: +1436.6 KB |
Contributor
📦 Calling bundle size
Total change: +1447.7 KB |
mgamis-msft
enabled auto-merge (squash)
October 7, 2026 15:44
Donald McEachern (dmceachernmsft)
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Typing indicators were incorrectly filtered as stale when the event timestamp differed from the receiving client’s clock. This fix replaces the SDK-provided receivedOn timestamp with the local receipt time before storing the event. Indicators now remain visible for the intended duration regardless of clock skew or delivery delay. A regression test verifies that events with stale timestamps are retained and expire normally.
Why
https://skype.visualstudio.com/OneWork/_workitems/edit/4784241 (this bug is happening in one particular device as described by TDL because the receiving client device clock is skewed more than 8 seconds resulting in client not able to see typing indicators)
https://portal.microsofticm.com/imp/v5/incidents/details/21000001135358/summary
How Tested
To replicate the scenario of the bug, I introduced a clock skey on the Windows receiving machine:
Set-Date -Date (Get-Date).AddSeconds(45)4 Reloaded the receiving Local chat sample.
From receiver's perspective

Before
After

Process & policy checklist
Is this a breaking change?