Skip to content

feat(avm/res/cognitive-services/account): extract deployments child module#7207

Open
dmytroslotvinskyy wants to merge 6 commits into
Azure:mainfrom
dmytroslotvinskyy:feat/cognitive-services-account-deployment-module
Open

feat(avm/res/cognitive-services/account): extract deployments child module#7207
dmytroslotvinskyy wants to merge 6 commits into
Azure:mainfrom
dmytroslotvinskyy:feat/cognitive-services-account-deployment-module

Conversation

@dmytroslotvinskyy

Copy link
Copy Markdown

Description

Extracts the Microsoft.CognitiveServices/accounts/deployments child resource from the inline implementation in account/main.bicep into a dedicated child module:

avm/res/cognitive-services/account/deployment/main.bicep

This implements the follow-up requested during the review of #7199 and tracked in #7206.

The parent account module continues to expose the existing deployments parameter and delegates each model deployment to the new child module. This preserves the current public interface and existing consumer behavior.

Changes

  • Added deployment/main.bicep containing the Microsoft.CognitiveServices/accounts/deployments resource.
  • Replaced the inline deployment resource loop with a module loop invoking the child module.
  • Exported deploymentType from the child module and imported it into the parent module.
  • Preserved @batchSize(1) to process model deployments serially.
  • Preserved optional modelProviderData support introduced in feat: avm/res/cognitive-services/account support `modelProviderData… #7199.
  • Preserved compatibility for existing deployments that do not provide modelProviderData.
  • Generated parent and child main.json and README.md files using Set-AVMModule -Recurse.
  • Updated CHANGELOG.md.

Dependency

This is a stacked follow-up PR based on the head branch of #7199. It should be rebased and retargeted to main after #7199 is merged.

Closes #7206

Pipeline Reference

Pipeline
avm.res.cognitive-services.account

Type of Change

  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation
  • Update to CI Environment or utilities (Non-module affecting changes)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • I have updated the module's CHANGELOG.md file with an entry for the next version

dmytroslotvinskyy and others added 6 commits July 7, 2026 08:55
…` for GA partner models (Anthropic Claude)

Adds optional `modelProviderData` (`organizationName`, `countryCode`, `industry`)
to `deploymentType` and projects it onto `Microsoft.CognitiveServices/accounts/deployments`.
This carries the model-provider attestation the Cognitive Services RP requires for GA
partner models such as Anthropic Claude (`model.format == 'Anthropic'`); the RP uses it
to auto-accept the partner's Azure Marketplace offer.

- Bump `accounts/deployments` API version 2025-06-01 -> 2026-05-01 (minimum GA version
  that accepts `properties.modelProviderData`). BCP081 is expected/suppressed as the
  version is newer than the current Bicep type catalog; it does not block deployment.
- Project `modelProviderData: deployment.?modelProviderData` (null-omitted when absent,
  same mechanics as `raiPolicyName`/`versionUpgradeOption`); first-party (OpenAI)
  deployments are unaffected.
- Add `ai-model-deployment-anthropic` e2e test.
- Bump module version 0.15 -> 0.16; update CHANGELOG, README, main.json.

Fixes Azure#7197
Co-authored-by: Erika Gressi <56914614+eriqua@users.noreply.github.com>
…child module

Move Microsoft.CognitiveServices/accounts/deployments into a dedicated deployment/main.bicep child module, invoked from the parent account module with @batchsize(1). Export the deployment input type from the child module and import it in the parent. Regenerate main.json and README for parent and child.
@dmytroslotvinskyy dmytroslotvinskyy requested review from a team as code owners July 11, 2026 09:39
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Needs: Triage 🔍 Maintainers need to triage still label Jul 11, 2026
@microsoft-github-policy-service

Copy link
Copy Markdown

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service Bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Jul 11, 2026
@microsoft-github-policy-service

Copy link
Copy Markdown

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: Implement Microsoft.CognitiveServices/accounts/deployments as a child resource via a deployment child module

1 participant