Skip to content

fix: Add Active Directory site support to NetApp account module AD configuration #7032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix: Add Active Directory site support to NetApp account module AD configuration #7032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8e6ab99
Initial plan
Copilot May 12, 2026
54de939
feat(net-app-account): add Active Directory site support
Copilot May 12, 2026
9affd7b
chore(net-app-account): sync compiled template for AD site parameter
Copilot May 12, 2026
7821108
fix(net-app-account): restore canonical resource type casing in README
Copilot May 12, 2026
9e92ec7
refactor(net-app-account): use activeDirectorySite parameter and null…
Copilot May 12, 2026
5d8c62a
docs(net-app-account): align activeDirectorySite ordering in README s…
Copilot May 12, 2026
7165374
docs(net-app-account): clarify activeDirectorySite description
Copilot May 12, 2026
d5c7098
docs(net-app-account): add changelog entry for AD site support
Copilot May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions avm/res/net-app/net-app-account/CHANGELOG.md
View file
Open in desktop

@eriqua eriqua May 22, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @fbinotto I see you raised this via copilot. Is this experimental or ready for review?
If ready, could you please add a pipeline badge proving the successful run in your fork?
If not ready, could you please set this as draft?

Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,16 @@

The latest version of the changelog can be found [here](https://github.com/Azure/bicep-registry-modules/blob/main/avm/res/net-app/net-app-account/CHANGELOG.md).

## 0.12.2

### Changes

- Added support for configuring the Active Directory site through the new `activeDirectorySite` parameter

### Breaking Changes

- None

## 0.12.1

### Changes
Expand Down
9 changes: 9 additions & 0 deletions avm/res/net-app/net-app-account/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1339,6 +1339,7 @@ param tags = {
| Parameter | Type | Description |
| :-- | :-- | :-- |
| [`adName`](#parameter-adname) | string | Name of the active directory host as part of Kerberos Realm used for Kerberos authentication. |
| [`activeDirectorySite`](#parameter-activedirectorysite) | string | The Active Directory site (as configured in Active Directory Sites and Services) the service will limit Domain Controller discovery to. |
| [`aesEncryption`](#parameter-aesencryption) | bool | Enable AES encryption on the SMB Server. |
| [`allowLocalNfsUsersWithLdap`](#parameter-allowlocalnfsuserswithldap) | bool | If enabled, NFS client local users can also (in addition to LDAP users) access the NFS volumes. |
| [`backupPolicies`](#parameter-backuppolicies) | array | The backup policies to create. |
Expand Down Expand Up @@ -1379,6 +1380,14 @@ Name of the active directory host as part of Kerberos Realm used for Kerberos au
- Type: string
- Default: `''`

### Parameter: `activeDirectorySite`

The Active Directory site (as configured in Active Directory Sites and Services) the service will limit Domain Controller discovery to.

- Required: No
- Type: string
- Default: `''`

### Parameter: `aesEncryption`

Enable AES encryption on the SMB Server.
Expand Down
4 changes: 4 additions & 0 deletions avm/res/net-app/net-app-account/main.bicep
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@ param lock lockType?
@description('Optional. A server Root certificate is required of ldapOverTLS is enabled.')
param serverRootCACertificate string = ''

@description('Optional. The Active Directory site (as configured in Active Directory Sites and Services) the service will limit Domain Controller discovery to.')
param activeDirectorySite string = ''

@eriqua eriqua May 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to make it nullable instead of adding an empty string default value?

Another comment would be that ideally, all paramrters should be validated via at least one e2e test. However I don't think it's applicable in this case


@description('Optional. Tags for all resources.')
param tags resourceInput<'Microsoft.NetApp/netAppAccounts@2025-01-01'>.tags?

Expand Down Expand Up @@ -97,6 +100,7 @@ var activeDirectoryConnectionProperties = [
ldapOverTLS: !empty(domainName) ? ldapOverTLS : false
ldapSigning: !empty(domainName) ? ldapSigning : false
serverRootCACertificate: !empty(domainName) ? serverRootCACertificate : null
site: !empty(domainName) && !empty(activeDirectorySite) ? activeDirectorySite : null
smbServerName: !empty(domainName) ? smbServerNamePrefix : null
organizationalUnit: !empty(domainJoinOU) ? domainJoinOU : null
allowLocalNfsUsersWithLdap: !empty(domainName) ? allowLocalNfsUsersWithLdap : false
Expand Down
44 changes: 26 additions & 18 deletions avm/res/net-app/net-app-account/main.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.42.1.51946",
"templateHash": "4503424678842499651"
"version": "0.43.8.12551",
"templateHash": "6572652601834220994"
},
"name": "Azure NetApp Files",
"description": "This module deploys an Azure NetApp Files Account and the associated resource types such as backups, capacity pools and volumes."
Expand Down Expand Up @@ -1271,6 +1271,13 @@
"description": "Optional. A server Root certificate is required of ldapOverTLS is enabled."
}
},
"activeDirectorySite": {
"type": "string",
"defaultValue": "",
"metadata": {
"description": "Optional. The Active Directory site (as configured in Active Directory Sites and Services) the service will limit Domain Controller discovery to."
}
},
"tags": {
"type": "object",
"metadata": {
Expand Down Expand Up @@ -1337,6 +1344,7 @@
"ldapOverTLS": "[if(not(empty(parameters('domainName'))), parameters('ldapOverTLS'), false())]",
"ldapSigning": "[if(not(empty(parameters('domainName'))), parameters('ldapSigning'), false())]",
"serverRootCACertificate": "[if(not(empty(parameters('domainName'))), parameters('serverRootCACertificate'), null())]",
"site": "[if(and(not(empty(parameters('domainName'))), not(empty(parameters('activeDirectorySite')))), parameters('activeDirectorySite'), null())]",
"smbServerName": "[if(not(empty(parameters('domainName'))), parameters('smbServerNamePrefix'), null())]",
"organizationalUnit": "[if(not(empty(parameters('domainJoinOU'))), parameters('domainJoinOU'), null())]",
"allowLocalNfsUsersWithLdap": "[if(not(empty(parameters('domainName'))), parameters('allowLocalNfsUsersWithLdap'), false())]"
Expand Down Expand Up @@ -1498,8 +1506,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.42.1.51946",
"templateHash": "184037223586394239"
"version": "0.43.8.12551",
"templateHash": "2430242282388418364"
},
"name": "Azure NetApp Files Backup Policy",
"description": "This module deploys a Backup Policy for Azure NetApp File."
Expand Down Expand Up @@ -1679,8 +1687,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.42.1.51946",
"templateHash": "10494004739943739336"
"version": "0.43.8.12551",
"templateHash": "10122502969748585395"
},
"name": "Azure NetApp Files Snapshot Policy",
"description": "This module deploys a Snapshot Policy for an Azure NetApp File."
Expand Down Expand Up @@ -2025,8 +2033,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.42.1.51946",
"templateHash": "11230557391605073788"
"version": "0.43.8.12551",
"templateHash": "12569309095828956979"
},
"name": "Azure NetApp Files Volume Backup Vault",
"description": "This module deploys a NetApp Files Backup Vault."
Expand Down Expand Up @@ -2197,8 +2205,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.42.1.51946",
"templateHash": "8944427053144847794"
"version": "0.43.8.12551",
"templateHash": "14326005862235618440"
},
"name": "Azure NetApp Files Volume Backup",
"description": "This module deploys a backup of a NetApp Files Volume."
Expand Down Expand Up @@ -2437,8 +2445,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.42.1.51946",
"templateHash": "6507019057705966012"
"version": "0.43.8.12551",
"templateHash": "18186745091332759013"
},
"name": "Azure NetApp Files Capacity Pools",
"description": "This module deploys an Azure NetApp Files Capacity Pool."
Expand Down Expand Up @@ -3297,8 +3305,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.42.1.51946",
"templateHash": "14589455478287977431"
"version": "0.43.8.12551",
"templateHash": "5637234170335079275"
},
"name": "Azure NetApp Files Capacity Pool Volumes",
"description": "This module deploys an Azure NetApp Files Capacity Pool Volume."
Expand Down Expand Up @@ -4146,8 +4154,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.42.1.51946",
"templateHash": "11230557391605073788"
"version": "0.43.8.12551",
"templateHash": "12569309095828956979"
},
"name": "Azure NetApp Files Volume Backup Vault",
"description": "This module deploys a NetApp Files Backup Vault."
Expand Down Expand Up @@ -4318,8 +4326,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.42.1.51946",
"templateHash": "8944427053144847794"
"version": "0.43.8.12551",
"templateHash": "14326005862235618440"
},
"name": "Azure NetApp Files Volume Backup",
"description": "This module deploys a backup of a NetApp Files Volume."
Expand Down
Loading