Skip to content

feat: Publish all child modules of avm/res/insights/component#6920

Merged
AlexanderSehr merged 4 commits into
mainfrom
users/krbar/cmp-component
May 25, 2026
Merged

feat: Publish all child modules of avm/res/insights/component#6920
AlexanderSehr merged 4 commits into
mainfrom
users/krbar/cmp-component

Conversation

@krbar

@krbar krbar commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

Description

Publish child modules of avm/res/insights/component to the Bicep public registry.

  • linked-storage-account

Changes per child module

  • Added enableTelemetry parameter
  • Added avmTelemetry resource with official telemetry prefix
  • Created version.json (version 0.1)
  • Created CHANGELOG.md (initial version 0.1.0)

Parent module changes

  • Added enableReferencedModulesTelemetry = false variable
  • Pass enableTelemetry: enableReferencedModulesTelemetry to child module deployment
  • Bumped CHANGELOG version from 0.7.1 to 0.7.2
  • Regenerated main.json and README.md

Pipeline Reference

avm.res.insights.component

Type of Change

  • Update to CI Environment or utilities (No module changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and target a PATCH version increment (0.1.0 -> 0.1.1)
    • Feature update backwards-compatible feature updates, and they target a MINOR version increment (0.1.0 -> 0.2.0)
    • Breaking changes and they target a MAJOR version increment (0.1.0 -> 1.0.0)
  • Changes to documentation

@microsoft-github-policy-service microsoft-github-policy-service Bot added the Needs: Triage 🔍 Maintainers need to triage still label Apr 18, 2026
@microsoft-github-policy-service

Copy link
Copy Markdown

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service Bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Apr 18, 2026
@microsoft-github-policy-service

Copy link
Copy Markdown

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@krbar krbar self-assigned this Apr 18, 2026
@krbar krbar temporarily deployed to avm-validation April 18, 2026 20:54 — with GitHub Actions Inactive
@krbar krbar temporarily deployed to avm-validation April 18, 2026 20:54 — with GitHub Actions Inactive
@krbar krbar temporarily deployed to avm-validation April 18, 2026 20:54 — with GitHub Actions Inactive
@krbar krbar marked this pull request as ready for review April 18, 2026 21:05
@krbar krbar requested review from a team as code owners April 18, 2026 21:05
@krbar krbar requested a review from Copilot April 18, 2026 21:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR publishes the linked-storage-account child module under avm/res/insights/component and wires it into the parent component module with AVM telemetry support patterns.

Changes:

  • Adds a publishable child module (linked-storage-account) with enableTelemetry, telemetry deployment resource, version.json, and initial CHANGELOG.md.
  • Updates the parent component module to disable telemetry for referenced modules and pass enableTelemetry: false into the child deployment.
  • Regenerates compiled ARM templates and bumps the parent module changelog.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
avm/res/insights/component/main.bicep Adds enableReferencedModulesTelemetry and passes it to the child module.
avm/res/insights/component/main.json Regenerated template reflecting referenced-module telemetry disablement and child param wiring.
avm/res/insights/component/CHANGELOG.md Bumps version and notes publishing the new child module.
avm/res/insights/component/linked-storage-account/main.bicep Introduces enableTelemetry and the AVM telemetry deployment resource.
avm/res/insights/component/linked-storage-account/main.json Regenerated template for the child module including telemetry plumbing.
avm/res/insights/component/linked-storage-account/README.md Regenerated docs to include new parameter and telemetry disclosure section.
avm/res/insights/component/linked-storage-account/CHANGELOG.md Adds initial changelog for the child module.
avm/res/insights/component/linked-storage-account/version.json Adds version file for registry publishing (0.1).

Comment thread avm/res/insights/component/linked-storage-account/README.md
Comment thread avm/res/insights/component/linked-storage-account/README.md Outdated
@krbar krbar added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Apr 20, 2026
krbar added 3 commits May 19, 2026 00:10
- Updated the description for the resource group output in the Application Insights Linked Storage Account module to clarify it refers to the Linked Storage Account.
- Updated metadata version and template hash for consistency across files.
@krbar krbar temporarily deployed to avm-validation May 19, 2026 08:44 — with GitHub Actions Inactive
@krbar krbar temporarily deployed to avm-validation May 19, 2026 08:44 — with GitHub Actions Inactive
@krbar krbar temporarily deployed to avm-validation May 19, 2026 08:44 — with GitHub Actions Inactive
@AlexanderSehr AlexanderSehr merged commit f15b87f into main May 25, 2026
19 checks passed
@AlexanderSehr AlexanderSehr deleted the users/krbar/cmp-component branch May 25, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Core Team 🧞 This item needs the AVM Core Team to review it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants