-
Notifications
You must be signed in to change notification settings - Fork 67
Adding quickstart for validate with a Linux image #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| { | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you please share details on how this has been tested? |
||
| "location": "westus2", | ||
| "identity": { | ||
| "type": "UserAssigned", | ||
| "userAssignedIdentities": { | ||
| "/subscriptions/<subscriptionID>/resourceGroups/<identityResourceGroup>/providers/Microsoft.ManagedIdentity/userAssignedIdentities/<managedIdentity>": {} | ||
| } | ||
| }, | ||
| "properties": { | ||
| "source": { | ||
| "type": "PlatformImage", | ||
| "publisher": "Canonical", | ||
| "offer": "UbuntuServer", | ||
| "sku": "16.04-LTS", | ||
| "version": "latest" | ||
| }, | ||
| "customize": [ | ||
| { | ||
| "type": "Shell", | ||
| "name": "AddBuildArtifacts3", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. NIT: What is the significance of 3 here? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please fix indentation. |
||
| "inline": [ | ||
| "sudo mkdir /buildArtifacts3", | ||
| "sudo touch /buildArtifacts3/imageBuilder.md" | ||
| ] | ||
| } | ||
|
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unnecessary blank line |
||
| ], | ||
| "validate": { | ||
| "continueDistributeOnFailure": false, | ||
| "inVMValidations": [ | ||
| { | ||
| "type": "Shell", | ||
| "name": "test shell validator inline", | ||
| "inline": [ | ||
| "echo HelloValidate", | ||
| "echo ByeValidate" | ||
| ] | ||
| }, | ||
| { | ||
| "type": "Shell", | ||
| "name": "<scriptName>", | ||
| "scriptUri": "<scriptUri>" | ||
| } | ||
| ] | ||
| }, | ||
| "distribute": [ | ||
| { | ||
| "type": "SharedImage", | ||
| "galleryImageId": "/subscriptions/<subscriptionID>/resourceGroups/<resourceGroupName>/providers/Microsoft.Compute/galleries/<sharedImageGalName>/images/<imageDefName>", | ||
| "runOutputName": "<runOutputName>", | ||
| "replicationRegions": [ | ||
| "westus2" | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the filename consistent with existing naming scheme.
If current scheme doesn't seem okay to you then please change the scheme for all of them - but the customer should have a consistent experience.