feat: Add support for Azure SQL AAD Users#5104
Open
TheiLLeniumStudios wants to merge 6 commits into
Open
Conversation
TheiLLeniumStudios
requested review from
davefellows,
jakjang,
matthchr and
theunrepentantgeek
as code owners
github-project-automation
Bot
moved this to In Progress
in Azure Service Operator Roadmap
TheiLLeniumStudios
changed the title
Author
|
@microsoft-github-policy-service agree |
|
|
||
| func Test_AzureSQL_AADUser(t *testing.T) { | ||
| t.Parallel() | ||
| t.Skip("Cannot run in CI currently due to AAD tenant restrictions on CI subscription") |
Member
There was a problem hiding this comment.
I suspect this test can run in our CI subscription - I believe the policy/restriction prohibits local users. We'll check this at our end.
Author
There was a problem hiding this comment.
Alright. Please let me know after confirming if that's the case, and I'll enable this test
matthchr
reviewed
Feb 3, 2026
matthchr
left a comment
matthchr
left a comment
Member
There was a problem hiding this comment.
Sorry for the slow response on this - thank you for sending this PR.
Can you share some more details about how you tested this?
| resource, ok := obj.(*v1.User) | ||
| if !ok { | ||
| return fmt.Errorf("expected github.com/Azure/azure-service-operator/v2/api/dbforpostgresql/v1/User, but got %T", obj) | ||
| return fmt.Errorf("expected github.com/Azure/azure-service-operator/v2/api/sql/v1/User, but got %T", obj) |
| @@ -0,0 +1,218 @@ | |||
| --- | |||
Member
There was a problem hiding this comment.
This file should not be here. It should get automatically generated + included in config/crd/generated/bases by our tooling, it doesn't need to be checked in here.
theunrepentantgeek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds Azure Active Directory (AAD) user support to the Azure SQL User CRD, enabling token-based authentication for managed identities, service principals, AAD users, and AAD groups.
Changes:
Example usage:
Closes #3700
How does this PR make you feel?
Checklist